Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cb/docs fixes #989

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Cb/docs fixes #989

merged 4 commits into from
Jul 19, 2023

Conversation

claytonpbarrows
Copy link
Member

this should fix a few docs issues, including the missing items to make the tutorials work correctly

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

Performance Results

Version Precompile Time
Main 7.837558114
This Branch 7.793085769
Version Build Time
Main-Build Time Precompile 73.424605568
Main-Build Time Postcompile 3.953895366
This Branch-Build Time Precompile 75.368408248
This Branch-Build Time Postcompile 3.907239943

@claytonpbarrows claytonpbarrows changed the base branch from main to jd/custom_model_improvements July 19, 2023 17:46
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #989 (c26c0ca) into jd/custom_model_improvements (b242964) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                      @@
##           jd/custom_model_improvements     #989   +/-   ##
=============================================================
  Coverage                         81.62%   81.62%           
=============================================================
  Files                               113      113           
  Lines                             12106    12106           
=============================================================
  Hits                               9882     9882           
  Misses                             2224     2224           
Flag Coverage Δ
unittests 81.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/parameters.jl 74.77% <ø> (ø)

@jd-lara jd-lara merged commit fd6c846 into jd/custom_model_improvements Jul 19, 2023
7 of 8 checks passed
@jd-lara jd-lara deleted the cb/docs_fixes branch July 19, 2023 21:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants