Variable Cost Refactor Part 2: PowerSimulations #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactor is not done yet and tests are not passing, but to proceed
with the refactor I need to make a decision that I'd like to be able to
easily revert if it ends up being the wrong one. Done so far:
- Update documentation given FunctionData
- Update all VariableCosts to refer to FunctionData
- Update most cost-looking tuples to FunctionData
Not done:
- `moi_tests` still fail
- There is still a conflict in the typing of the data stored in
parameter containers
- Probably more issues I haven't gotten to in the tests yet
This was referenced Feb 26, 2024
|
The group of four PRs this is a part of: |
jd-lara
reviewed
Feb 26, 2024
jd-lara
reviewed
Feb 26, 2024
jd-lara
reviewed
Feb 26, 2024
jd-lara
requested changes
Feb 26, 2024
jd-lara
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second part of a significant refactor of Sienna cost data structures (part 1 is here). The main focus here is to bring PowerSimulations.jl up to date with the elimination of
VariableCostin favor ofFunctionData. That entails these changes in PowerSimulations:VariableCost, and some instances of contents ofVariableCost, withFunctionDataOn the latter point, I am not completely sure if I made the switch from using
FunctionDatato using raw data (vectors of tuples) at the proper place; I'd appreciate review of that.Tests pass:
