[DNMY] Support in the loop PowerFlow evaluation #1040
Conversation
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
| pf_data = get_power_flow_data(pf_e_data) | ||
| # Maps the StaticInjection component type by name to the | ||
| # index in the PowerFlow data arrays going from Bus number to bus index | ||
| temp_component_bus_map = Dict{DataType, Dict{String, Int}}() |
There was a problem hiding this comment.
It looks like wherever temp_component_bus_map is read, both a type and a name are being passed in to get directly to a bus number. Since we never make use of the nested structure, I'd recommend Dict{Tuple{DataType, String}, Int}; that should also simplify the first loop a bit.
| name_bus_ix_map = Dict{String, Int}() | ||
| comp_type = get_component_type(key) | ||
| push!(added_injection_types, comp_type) | ||
| for n in axes(array)[1] |
There was a problem hiding this comment.
Assuming n here is a component name because that is how it is used, maybe rename so it doesn't sound like a number. Also, what would be the best way for me to obtain a typical OptimizationContainer that would get passed to this function so I can experiment with how it works?
| end | ||
|
|
||
| for (key, array) in get_aux_variables(container) | ||
| if get_entry_type(key) ∉ ACTIVE_POWER_INJECTION_KEYS |
There was a problem hiding this comment.
Helper function-ify the entire loop to avoid code duplication across variables, aux_variables, parameters
This is a WIP branch to integrate the evaluation of PowerFlows into a simulation loop.