[feat/#4] week2 - compose / essential(필수) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckkim817
reviewed
Apr 19, 2024
| } | ||
| } | ||
|
|
||
| } |
2hyunjinn
reviewed
Apr 19, 2024
| import com.sopt.now.compose.user.UserItem | ||
|
|
||
|
|
||
| val userList = listOf<UserInfo>( |
2hyunjinn
reviewed
Apr 19, 2024
2hyunjinn
reviewed
Apr 19, 2024
| val nickname: String, | ||
| val mbti: String | ||
| ) : Parcelable { | ||
| constructor(parcel: Parcel) : this( |
leeeyubin
reviewed
Apr 19, 2024
Comment on lines
+46
to
+48
| Text( | ||
| text = "사용자 정보를 불러올 수 없습니다.", | ||
| fontSize = 20.sp, |
Comment on lines
82
to
88
| ) { | ||
| LazyColumn { | ||
| items(userList) { | ||
| UserItem(it) | ||
| } | ||
| items(friendList) { | ||
| FriendItem(it) |
There was a problem hiding this comment.
나경이두 요거 하나의 데이터로 만들어서 연결하는 법 알아보면 좋을 것 같아요!
2hyunjinn
reviewed
Apr 20, 2024
| import com.sopt.now.compose.user.UserInfo | ||
|
|
||
| class MainActivity : ComponentActivity() { | ||
| companion object { |
There was a problem hiding this comment.
companion object는 마지막에 위치시키는게 컨벤션 규칙이래요!
2hyunjinn
reviewed
Apr 20, 2024
| } | ||
| @OptIn(ExperimentalMaterial3Api::class) | ||
| @Composable | ||
| fun Scaffold(userInfo: UserInfo?) { |
There was a problem hiding this comment.
MainScaffold로 바꿔서 Jetpack Compose의 Scaffold와 구분하는게 좋을 것 같습니다!
2hyunjinn
reviewed
Apr 20, 2024
| titleContentColor = MaterialTheme.colorScheme.primary, | ||
| ), | ||
| title = { | ||
| Text("NOW SOPT 34th ANDROID") |
MoonsuKang
approved these changes
Apr 21, 2024
| // search 페이지 구현 x | ||
| } | ||
| 2 -> { | ||
| if (userInfo != null) { |
leeeyubin
approved these changes
Apr 21, 2024
leeeyubin
reviewed
Apr 21, 2024
Comment on lines
+14
to
+17
| sealed class HomeData { | ||
| data class UserInfoData(val userInfo: UserInfo) : HomeData() | ||
| data class FriendData(val friend: Friend) : HomeData() | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📗 WORK DESCRIPTION
todo list
📗VIDEO (RUN)
2week-compose-essential.mp4
📗TO REVIEWERS
UserInfo 마이페이지 부분은 추가 수정하겠습니다ㅇ....