forked from ufs-community/ufs-srweather-app
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fewer ifi fields #247
Closed
SamuelTrahanNOAA
wants to merge
25
commits into
NOAA-GSL:feature/RRFS_dev1
from
SamuelTrahanNOAA:fewer-ifi-fields
Closed
Fewer ifi fields #247
SamuelTrahanNOAA
wants to merge
25
commits into
NOAA-GSL:feature/RRFS_dev1
from
SamuelTrahanNOAA:fewer-ifi-fields
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## DESCRIPTION OF CHANGES: Update hash of regional_workflow to the latest PR (#[421](https://github.com/NOAA-EMC/regional_workflow/pull/421)) in the regional_workflow repo. ## TESTS CONDUCTED: See PR #[421](https://github.com/NOAA-EMC/regional_workflow/pull/421) into regional_workflow.
## DESCRIPTION OF CHANGES: Update hash of regional_workflow to the latest PR (#[450](https://github.com/NOAA-EMC/regional_workflow/pull/450)) in the regional_workflow repo. ## TESTS CONDUCTED: See PR #[450](https://github.com/NOAA-EMC/regional_workflow/pull/450) into regional_workflow.
…o be less v1.0.0 specific.
…ixes, add Cheyenne workflow file (ufs-community#130) * Bring over documentation from release branch * Bring over cheyenne workflow file from release branch * Users guide spelling fixes from Jamie * A few more spelling fixes, capitalization consistency in Users Guide * Fix some merge weirdness in docs/INSTALL * Remove SystemRequirements.rst which is no longer needed (incorporated into another chapter)
…y#135) - Update Externals.cfg to point to hash of UFS_UTILS with bug fix - Update Quickstart documentation accordingly Out-of-the-box case builds with GNU and workflow runs to completion on Cheyenne.
…-stack (ufs-community#138) * Update the build environment for wcoss dell * Update the build environment for wcoss cray * Update the build environment for Hera * Update build environment for Orion * Rearrange modules in alphabetical order * Remove unnecessary modules
Add templates for bug and feature issues.
…l (hash 2f1c8e1) (ufs-community#140) ## DESCRIPTION OF CHANGES: This PR (along with https://github.com/NOAA-EMC/regional_workflow/pull/492) update the UFS SRW App to work with a more up-to-date hash of the ufs-weather-model (ufs-community/ufs-weather-model@2f1c8e1) ## TESTS CONDUCTED: Ran full suite of tests on Hera (aside from nco tests) with updated environment files (/scratch2/BMC/det/kavulich/workdir/update_app_master/step-by-step/expt_dirs/). The only new failures are only for older versions of NAM input; this is due to a change in the weather model, and will need to be handled in a separate PR. Ran several end-to-end tests on Cheyenne (Intel 19.1.1) and Jet. Also ran the Graduate Student Test case on Orion. No failures outside of those outlined above and a few previously-known failures. **Tests have not been run on WCOSS platforms; these will likely fail without being updated to the latest ESMF modules but DTC does not have access to update and test** ## ISSUE: Fixes issue ufs-community#134
…ommunity#146) * Match the name of forecast model with repo * Match the name of forecast with repo * Match the name of forecast model with repo
* Add inline_post flag to build config * Update env for wcoss dell * Update to the latest versions * Update hash of regional workflow
Update ufs-weather-model to 3b8bb78: * Requires new revision of regional_workflow with fd_nems.yaml * Updated cmake revision to env files * Added fms module load to env files
## DESCRIPTION OF CHANGES: Bug fix for PR ufs-community#152: `hase` -> `hash` in Externals.cfg. ## TESTS CONDUCTED: None.
* Add arguments to devbuild.sh script * Documented with --help * Automatically determines machine name * Automatically determines compiler based on machine name * Added options for app, ccpp suite, and components * Added option for build type DEBUG, RELEASE, RELWITHDEBINFO * Added option for build jobs, default 4 * Added verbosity option for make * Require PLATFORM in devbuild.sh script * Modify devbuild.sh options * remove --components * add --enable-options * add --disable-options
* Add test/build.sh to build all executables for supported compilers on platforms Cheyenne, Hera and Jet. Add test/README.md file for usage. All builds succeed on Cheyenne. * Address Gerard's and Christina's comments: - Remove -l from top of script - Use ${BIN_DIR} for cmake command - Use $() for easier debugging * Use the devbuild.sh script for the build tests. * Fix typo Remove irrelevent comment block
…nity#167) * Update EMC_post hash to top of develop; way overdue! * Use BUILD_ALWAYS flags in CMakeLists.txt so that code changes result in a rebuild * Load rocoto in wflow_hera.env, since it may have been unloaded at the build step * Point to required regional_workflow branch for testing; will update to proper hash once PR is merged * Point to latest regional_workflow hash
SamuelTrahanNOAA
requested review from
christinaholtNOAA,
chunhuazhou,
CurtisAlexander-NOAA,
hu5970 and
JeffBeck-NOAA
as code owners
September 15, 2023 20:18
SamuelTrahanNOAA
requested review from
terraladwig,
TrevorAlcott-NOAA,
guoqing-noaa,
daviddowellNOAA,
JacobCarley-NOAA,
MatthewPyle-NOAA,
ShunLiu-NOAA and
JiliDong-NOAA
as code owners
September 15, 2023 20:18
Something went wrong with this PR. I'll close it and open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the top of UPP and updates the regional_workflow post control files to match UPP's latest.