Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build environment files for Hera, Orion, WCOSS with latest hpc-stack #138

Merged
merged 13 commits into from
May 13, 2021
Merged

Update build environment files for Hera, Orion, WCOSS with latest hpc-stack #138

merged 13 commits into from
May 13, 2021

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented May 6, 2021 •
edited
Loading

DESCRIPTION OF CHANGES:

  • Updated the build environment files env/build_[machine]_[compiler].env for Hera, Orion, and WCOSS with the latest hpc-stack.
  • Rearranged the module list in alphabetical order for easy maintenance.

TESTS CONDUCTED:

  • Completed the GST test successfully on Hera, Orion, and WCOSS Dell and Cray.

ISSUE:

@JeffBeck-NOAA
Copy link
Collaborator

@chan-hoo, thank you for updating the umbrella repo to use the latest hpc-stack! @mkavulich, thoughts on this PR?

JeffBeck-NOAA
JeffBeck-NOAA reviewed May 6, 2021
View reviewed changes
env/build_hera_intel.env
@@ -2,42 +2,54 @@

module purge

# UFS_UTILS
module load hpss
module load cmake/3.16.1
Copy link
Collaborator

@JeffBeck-NOAA JeffBeck-NOAA May 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should # UFS_UTILS be listed above these two modules? HPSS is only used for the exregional_get_extrn_mdl_files.sh script and cmake is for everything (comment applies to all environment files).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffBeck-NOAA, The comment means the order of UFS_UTILS -> ufs-weather-model -> EMC_post (order in Externals.cfg). It doesn't mean a specific component. This is the reason why I put '+' before EMC_post or ufs-weather-model in comments (for example, # + EMC_post). I used it as an indicator of 'in addition'. If you think these comments make users confused, I'll remove all the comments and rearrange the modules in the alphabetical order.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @chan-hoo. I'm honestly still confused, but it could just be me. I was thinking they were block headers that represent which modules apply to which App component. How do they represent the Externals.cfg file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffBeck-NOAA, I've removed all the comments about components and rearranged modules only in alphabetical order. I'll test building on each machine again.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffBeck-NOAA, completed!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chan-hoo! This looks good to me. Going to approve, but would like to have @mkavulich's review as well.

mkavulich
mkavulich reviewed May 11, 2021
View reviewed changes
Copy link
Collaborator

@mkavulich mkavulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no comments on the wcoss changes (I have no access) but I do have some questions about the changes to the Hera and Orion environment.

env/build_hera_intel.env Outdated Show resolved Hide resolved
env/build_hera_intel.env Show resolved Hide resolved
env/build_orion_intel.env Outdated Show resolved Hide resolved
@chan-hoo chan-hoo merged commit de9bd9f into ufs-community:master May 13, 2021
@chan-hoo chan-hoo deleted the feature/build_env branch May 13, 2021 10:32
christopherwharrop-noaa pushed a commit to christopherwharrop-noaa/ufs-srweather-app that referenced this pull request Apr 12, 2022
@hu5970
Update hash for recent bug fix in regional work flow and adding GWD o…
fbe49fd 
…ptions. (ufs-community#138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBeck-NOAA JeffBeck-NOAA JeffBeck-NOAA approved these changes

@mkavulich mkavulich mkavulich approved these changes

@gsketefian gsketefian Awaiting requested review from gsketefian

@JulieSchramm JulieSchramm Awaiting requested review from JulieSchramm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chan-hoo @JeffBeck-NOAA @mkavulich