-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build environment files for Hera, Orion, WCOSS with latest hpc-stack #138
Conversation
@chan-hoo, thank you for updating the umbrella repo to use the latest hpc-stack! @mkavulich, thoughts on this PR? |
@@ -2,42 +2,54 @@ | |||
|
|||
module purge | |||
|
|||
# UFS_UTILS | |||
module load hpss | |||
module load cmake/3.16.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should # UFS_UTILS be listed above these two modules? HPSS is only used for the exregional_get_extrn_mdl_files.sh script and cmake is for everything (comment applies to all environment files).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBeck-NOAA, The comment means the order of UFS_UTILS -> ufs-weather-model -> EMC_post (order in Externals.cfg). It doesn't mean a specific component. This is the reason why I put '+' before EMC_post or ufs-weather-model in comments (for example, # + EMC_post). I used it as an indicator of 'in addition'. If you think these comments make users confused, I'll remove all the comments and rearrange the modules in the alphabetical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @chan-hoo. I'm honestly still confused, but it could just be me. I was thinking they were block headers that represent which modules apply to which App component. How do they represent the Externals.cfg file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBeck-NOAA, I've removed all the comments about components and rearranged modules only in alphabetical order. I'll test building on each machine again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBeck-NOAA, completed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @chan-hoo! This looks good to me. Going to approve, but would like to have @mkavulich's review as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no comments on the wcoss changes (I have no access) but I do have some questions about the changes to the Hera and Orion environment.
DESCRIPTION OF CHANGES:
env/build_[machine]_[compiler].env
for Hera, Orion, and WCOSS with the latest hpc-stack.TESTS CONDUCTED:
ISSUE: