-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the MYNN surface layer scheme #67
Conversation
updating fork
updating fork
…20201118 Update gsd/develop from master 2020/11/18
update branch
…using unitialized variable when 100% ice melts or ice develops on a grid with 0% ice, 3) reduced overly liberal range of allowable z/L.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These code changes look good to me. I am going to test this now with the noaa-gsl ufs-weather-model and create the corresponding PRs for fv3atm and ufs-weather-model.
Will approve after testing is complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joeolson42 update - your PR is not up to date. Can you please check that you have pulled in the latest code from https://github.com/noaa-gsl/ccpp-physics, branch gsl/develop ? And then push the update to your branch. Thanks.
I updated my fork yesterday, but perhaps I updated it from gsd/develop
instead of gsl/develop by accident???
…On Tue, Dec 15, 2020 at 2:47 PM DomHeinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
@joeolson42 <https://github.com/joeolson42> update - your PR is not up to
date. Can you please check that you have pulled in the latest code from
https://github.com/noaa-gsl/ccpp-physics, branch gsl/develop ? And then
push the update to your branch. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#67 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLRR3XRJRSDND5BX3RWTK3SU7KP7ANCNFSM4U3OWF4Q>
.
--
Joseph Olson
Meteorologist
Environmental Prediction Advancement Division
Global Systems Laboratory
NOAA-Earth System Research Labs
Boulder, Colorado
|
Yes, that's what it looks like.
… On Dec 15, 2020, at 3:00 PM, Joseph Olson ***@***.***> wrote:
I updated my fork yesterday, but perhaps I updated it from gsd/develop
instead of gsl/develop by accident???
On Tue, Dec 15, 2020 at 2:47 PM DomHeinzeller ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
>
> @joeolson42 <https://github.com/joeolson42> update - your PR is not up to
> date. Can you please check that you have pulled in the latest code from
> https://github.com/noaa-gsl/ccpp-physics, branch gsl/develop ? And then
> push the update to your branch. Thanks.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#67 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADLRR3XRJRSDND5BX3RWTK3SU7KP7ANCNFSM4U3OWF4Q>
> .
>
--
Joseph Olson
Meteorologist
Environmental Prediction Advancement Division
Global Systems Laboratory
NOAA-Earth System Research Labs
Boulder, Colorado
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#67 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN7FF5H5XB4SR5IC57CPIA3SU7MAFANCNFSM4U3OWF4Q>.
|
updating from gsl/develop instead of gsd/develop
Ok, this is better. Will start testing. |
@joeolson42 quick update, the regression tests look good, I'll update the ufs-weather-model PR with a few details in a minute and then merge the code. |
This update includes the following fixes/mods:
Associated PRs:
#67
NOAA-GSL/fv3atm#63
NOAA-GSL/ufs-weather-model#52
For regression testing, see NOAA-GSL/ufs-weather-model#52.