Name refactoring for tests, growth, and median

[nathanvaughan-NOAA]

What is the feature?

• Refactoring test names to remove _ and match google style recommendations
• Refactoring population to use weight_at_age[] vector instead of growth evaluate function
• Refactoring to replace the median parameter with inflection_point to be more descriptive and avoid overlap with R function names

How have you implemented the solution?

We have refactored the code base to change names as described.

Does the PR impact any other area of the project?

No this should not impact the rest of the code

How to test this change

Developer pre-PR checklist

• I relied on GitHub actions to 🧪 things for me while I sat on the 🛋️.

[nathanvaughan-NOAA]

We know we are a couple of commits behind main but given the large number of open pull requests we were leaving another rebase until this is ready to be merged into main.

[Bai-Li-NOAA]

This looks great! Thanks for the name refactoring. I can help with merging these changes into the main branch once the conflicts are resolved.

[codecov]

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
R/create_rcpp_interface_object.R	0.00% <ø> (ø)
inst/include/common/fims_math.hpp	100.00% <100.00%> (ø)
inst/include/interface/rcpp/rcpp_interface.hpp	71.06% <100.00%> (ø)
...population_dynamics/maturity/functors/logistic.hpp	100.00% <ø> (ø)
...lude/population_dynamics/population/population.hpp	100.00% <100.00%> (ø)
..._dynamics/selectivity/functors/double_logistic.hpp	100.00% <ø> (ø)
...ulation_dynamics/selectivity/functors/logistic.hpp	100.00% <ø> (ø)
...lude/interface/rcpp/rcpp_objects/rcpp_maturity.hpp	82.85% <50.00%> (ø)
...e/interface/rcpp/rcpp_objects/rcpp_selectivity.hpp	54.54% <38.88%> (ø)

... and 8 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

[nathanvaughan-NOAA]

@ChristineStawitz-NOAA Looks like we already found a scenario where the merge block is an issue. This pull request says it cannot be rebased due to conflicts and it will now only let me choose Squash and merge which I don't want to do because these are 4 different issues that would be best kept separate for future interpretability.

[ChristineStawitz-NOAA]

@nathanvaughan-NOAA I came to the same conclusion once I tried to approve :) I removed that setting

[nathanvaughan-NOAA]

Hahaha sounds good, I'll merge once I fix these merge conflicts :)