Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update windows-2019 to windows-latest #495

Conversation

Bai-Li-NOAA
Copy link
Contributor

What is the feature?

Update the Windows OS in the run-googletest GHA

How have you implemented the solution?

Replace windows-2019 with windows-latest.

Does the PR impact any other area of the project?

NA

How to test this change

All GHA checks have passed.

Developer pre-PR checklist

  • I relied on GitHub actions to 🧪 things for me while I sat on the 🛋️.

Co-authored-by: Huihualee-NOAA <Huihualee-NOAA@users.noreply.github.com>
Co-authored-by: Jon Kenton Tarsus Brodziak <jon.brodziak@noaa.gov>
@Bai-Li-NOAA Bai-Li-NOAA linked an issue Oct 28, 2023 that may be closed by this pull request
1 task
@github-actions
Copy link
Contributor

Instructions for code reviewer

Hello reviewer, thanks for taking the time to review this PR!

  • Please use this checklist during your review, checking off items that you have verified are complete!
  • For PRs that don't make changes to code (e.g., changes to README.md or Github actions workflows), feel free to skip over items on the checklist that are not relevant. Remember it is still important to do a thorough review.
  • Then, comment on the pull request with your review indicating where you have questions or changes need to be made before merging.
  • Remember to review every line of code you’ve been asked to review, look at the context, make sure you’re improving code health, and compliment developers on good things that they do.
  • PR reviews are a great way to learn, so feel free to share your tips and tricks. However, for optional changes (i.e., not required for merging), please include nit: (for nitpicking) before making the suggestion. For example, nit: I prefer using a data.frame() instead of a matrix because...
  • Engage with the developer when they respond to comments and check off additional boxes as they become complete so the PR can be merged in when all the tasks are fulfilled. Make it clear when this has been reached by commenting on the PR with something like This PR is now ready to be merged, no changes needed.

Checklist

  • The PR is requested to be merged into the appropriate branch (typically main)
  • The code is well-designed.
  • The functionality is good for the users of the code.
  • Any User Interface changes are sensible and look good.
  • The code isn’t more complex than it needs to be.
  • Code coverage remains high, indicating the new code is tested.
  • The developer used clear names for everything.
  • Comments are clear and useful, and mostly explain why instead of what.
  • Code is appropriately documented (doxygen and roxygen).

@Bai-Li-NOAA Bai-Li-NOAA requested review from a team and nathanvaughan-NOAA and removed request for a team October 28, 2023 16:10
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 13 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Member

@k-doering-NOAA k-doering-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

It looks like run-google-test on windows-2019 is a "required" build, so I think @ChristineStawitz-NOAA may need to toggle the PR merge settings so it looks for windows-latest instead in order to merge in!

@ChristineStawitz-NOAA ChristineStawitz-NOAA merged commit 6b2b3f7 into main Oct 30, 2023
14 checks passed
@ChristineStawitz-NOAA ChristineStawitz-NOAA deleted the 183-bug-error-in-google-test-gha-when-cxx-compiler-is-gnu-1120 branch October 30, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error in Google test GHA when CXX compiler is GNU 11.2.0
4 participants