-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update windows-2019 to windows-latest #495
fix: update windows-2019 to windows-latest #495
Conversation
Co-authored-by: Huihualee-NOAA <Huihualee-NOAA@users.noreply.github.com> Co-authored-by: Jon Kenton Tarsus Brodziak <jon.brodziak@noaa.gov>
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 13 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
It looks like run-google-test on windows-2019 is a "required" build, so I think @ChristineStawitz-NOAA may need to toggle the PR merge settings so it looks for windows-latest instead in order to merge in!
What is the feature?
Update the Windows OS in the run-googletest GHA
How have you implemented the solution?
Replace
windows-2019
withwindows-latest
.Does the PR impact any other area of the project?
NA
How to test this change
All GHA checks have passed.
Developer pre-PR checklist