-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
411 refactor naming convention of member and local variables in the fleet class #476
411 refactor naming convention of member and local variables in the fleet class #476
Conversation
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
Codecov ReportAttention:
... and 12 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
We should add documentation somewhere in the code, and also in the collaborative workflow doc, of the use of |
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
Co-authored-by: KyleShertzer-NOAA <KyleShertzer-NOAA@users.noreply.github.com> Co-authored-by: Jim Ianelli <jim.ianelli@gmail.com> Co-authored-by: Ian Taylor <iantaylor-NOAA@users.noreply.github.com> Co-authored-by: Andrea-Havron-NOAA <Andrea-Havron-NOAA@users.noreply.github.com>
a1d9a5d
to
a9666e0
Compare
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
@ChristineStawitz-NOAA Documentation has been added in the code and an issue has been submitted to the collaborative workflow repo. |
What is the feature?
Refactor member names in the fleet class
How have you implemented the solution?
Does the PR impact any other area of the project?
How to test this change
Passed GHA workflows can be found here
Developer pre-PR checklist