Add to fims refactor #453
Closed
Add to fims refactor #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msupernaw, this is failing checks on Ubuntu and Windows and needs a fix before a review |
|
@Andrea Havron - NOAA Federal ***@***.***> All tests are now
passing.
…On Wed, Aug 23, 2023 at 11:26 AM Andrea-Havron-NOAA < ***@***.***> wrote:
@msupernaw <https://github.com/msupernaw>, this is failing checks on
Ubuntu and Windows and needs a fix before a review
—
Reply to this email directly, view it on GitHub
<#453 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFUSEFOMBHMSIUL4RMN76LXWYOIXANCNFSM6AAAAAA32CLXJE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Matthew Supernaw
*Scientific Software Developer*
*National Oceanic and Atmospheric Administration*
*Office Of Science and Technology*
*NOAA Fisheries | *U.S. Department of Commerce
Phone 248 - 396 - 7797
|
|
This was originally branched off of |
|
ok, I'll take care of that today!
…On Tue, Aug 29, 2023 at 1:40 PM Christine Stawitz - NOAA < ***@***.***> wrote:
This was originally branched off of fims_test_estimation and so there are
some merge conflicts that seem not real. We probably want to start a new
branch of main and cherry-pick the commits in.
—
Reply to this email directly, view it on GitHub
<#453 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFUSEB2AHJTBFGDUTWOARTXXYSQ5ANCNFSM6AAAAAA32CLXJE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Matthew Supernaw
*Scientific Software Developer*
*National Oceanic and Atmospheric Administration*
*Office Of Science and Technology*
*NOAA Fisheries | *U.S. Department of Commerce
Phone 248 - 396 - 7797
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project?
How to test this change
Developer pre-PR checklist