fix: deploying pkgdown

[k-doering-NOAA]

What is the feature?

Fixes the package down site build so that we can deploy it to github pages. Thanks @iantaylor-NOAA for spotting this issue!

How have you implemented the solution?

remove a setting from the yaml that was rendering in a docs/dev subfolder

Does the PR impact any other area of the project?

No

How to test this change

run pkgdown::build_site() locally

Developer pre-PR checklist

• I relied on GitHub actions to 🧪 things for me while I sat on the 🛋️.

[codecov-commenter]

Codecov Report

Patch and project coverage have no change.

Comparison is base (a22ada1) 81.75% compared to head (764d0fd) 81.75%.

❗ Current head 764d0fd differs from pull request most recent head a74c1e2. Consider uploading reports for the commit a74c1e2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #448   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files          37       37           
  Lines        2006     2006           
=======================================
  Hits         1640     1640           
  Misses        366      366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Bai-Li-NOAA]

Looks great.

[iantaylor-NOAA]

@Bai-Li-NOAA and @k-doering-NOAA, thank you for working on this. I'm excited for the {pkgdown} magic.
Sadly there was an error in the workflow deploying the pkgdown site: https://github.com/NOAA-FIMS/FIMS/actions/runs/5871209885.

[k-doering-NOAA]

Thanks @iantaylor-NOAA , GitHub pages was trying to deploy from a folder rather than the root on the gh-actions branch - it should be fixed now! https://noaa-fims.github.io/FIMS/

[iantaylor-NOAA]

Looks beautiful, thank you!
So nice to see a vignette on the web instead of having to build locally.