Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: developer checklist not working as expected #441

Closed
k-doering-NOAA opened this issue Aug 15, 2023 · 2 comments
Closed

[Bug]: developer checklist not working as expected #441

k-doering-NOAA opened this issue Aug 15, 2023 · 2 comments
Labels
attribute: low hanging 🍎 Easy to knock off in less than 1 day kind: bug Something isn't working
Milestone
MQ

Comments

@k-doering-NOAA
Copy link
Member

Describe the bug

The developer checklist is only generated if someone marks a pull request as "ready for review", which does not happen on every pull request.

I think the intention was to have it generated on every pull request, but looking at the list, I wonder if we want to slim down the checklist (some things are tested by github actions), or do away with it altogether, if we feel like it is not useful.

To Reproduce

No response

Screenshots

No response

Which OS are you seeing the problem on?

No response

Which browser are you seeing the problem on?

No response

Which version of FIMS are you seeing the problem on?

No response

Additional Context

No response
@k-doering-NOAA k-doering-NOAA added the kind: bug Something isn't working label Aug 15, 2023
@ChristineStawitz-NOAA ChristineStawitz-NOAA added this to the MQ milestone Aug 15, 2023
@ChristineStawitz-NOAA
Copy link
Contributor

We should make the trigger when a PR is opened and remove a couple of the checklist items:

  1. parallel processing
  2. testing items - only relevant for new features

@Andrea-Havron-NOAA Andrea-Havron-NOAA added the status: triage_needed This is not approved for this milestone, do not work on it yet label Oct 4, 2023
@ChristineStawitz-NOAA ChristineStawitz-NOAA added attribute: low hanging 🍎 Easy to knock off in less than 1 day and removed status: triage_needed This is not approved for this milestone, do not work on it yet labels Oct 4, 2023
k-doering-NOAA added a commit that referenced this issue Oct 5, 2023
@k-doering-NOAA
#441: fix build trigger, edit checklist
78a2d6a
@k-doering-NOAA k-doering-NOAA mentioned this issue Oct 5, 2023
Merged
1 task
k-doering-NOAA added a commit that referenced this issue Oct 5, 2023
@k-doering-NOAA
Merge pull request #474 from NOAA-FIMS/441-dev-checklist
009f763 
#441: fix reviewer checklist build trigger, edit checklist
@k-doering-NOAA
Copy link
Member Author

merged in...we can refine the the pr checklist as needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
attribute: low hanging 🍎 Easy to knock off in less than 1 day kind: bug Something isn't working
Projects
No open projects
MQ
Status: Done
Milestone
MQ
Development

No branches or pull requests
3 participants
@ChristineStawitz-NOAA @k-doering-NOAA @Andrea-Havron-NOAA