-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEMS driver cleanup #98
NEMS driver cleanup #98
Conversation
Remove Theia (#10)
merge noaa-emc/nems develop
Change acc# on WCOSS to GFS-DEV (#17)
debug mode for NEMS, additional minor changes in component mk files (…
Code changes to support DEBUG compilation based on appBuilder specifi…
remove ice-ocean merge in prep_atm (#24)
add s4 rules (NOAA-EMC#49)
Update submodule pointer for NCEPLIBS-pyprodutil (NOAA-EMC#51)
Poring to Orion. (NOAA-EMC#53)
Remove CCPP dynamic build from NEMS (NOAA-EMC#54)
support for ufs-s2s-model debug compilaiton (NOAA-EMC#40)
cmeps integration changes (NOAA-EMC#55)
Bugfix i2a & Add Orion to module-setup (NOAA-EMC#61)
* update cice6 component mk * update path for forapps/ufs * update paths to MOM6 and CICE interfaces (#33) Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com> Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
* remove NEMS mediator files and Spaceweather Mediator file
* use fd_nems.yaml for FieldDictionary * remove unused FRONT_COMPONENT and DriverAddComp: * NMMB,GSM,MOM5,CICE5,POM,WRFHYDRO * "S" components, "X" components
Consider removing |
Now that we removed ensemble coupler there's no need to have both |
I also do not see where two variables in
are used. If they are not needed anymore, maybe |
There will be one more PR to clean up the driver itself but I think removing the NEMS internal state file would be OK at this point. |
Five subroutines from Functions |
I'm going to retain the I'm not sure what to do about the two |
None of the variables from two internal states are used. They (internal states) can be removed. |
I'd suggest to check with Mark Potts before removing the NEMS/earth internal state file. I am not sure if the JEDI-NEMS interface has been set up yet and if NEMS internal state will be used in that setting. |
I do not see how and why would JEDI access to nems and earth internal states. As the name suggests they are internal. If JEDI needs anything from nems grid component it should access it via import and/or export states. @mark-a-potts Can you please check if JEDI needs access to NEMS internal state. |
The plan is for JEDI to get all information via NUOPC imports and exports, so it will not use the internal states. |
The |
EARTH_INTERNAL_STATE is declared, allocated, stored in the grid component and finally deallocated. But it's never actually used. Same for nems internal state. They can be removed. |
Great. Now we just need to merge nems and earth component into one grid component, move check_esmf_pet to main program or use some alternative way of setting log type, figure out what to about these two rusage files and we'll be down to just main program and one grid component module. But that's for the next PR. |
@DeniseWorthen is this pr ready for commit? |
Yes it is but we haven't been merging the subcomponent PRs until the ufs-weather is updated w/ the RTs. Did you want to merge it now? |
@DeniseWorthen Yes let's wait for the ufs-weather RT results. |
/scratch2/NCEPDEV/nwprod/hpc-stack/src/hpc-stack/pkg/upp-upp_v10.0.6/sorc/ncep_post.fd/PROCESS.f:81: undefined reference to `timef_'
Fixes issue #95
c96dd29: remove NEMS mediator files
ac9558c: switch to yaml field dictionary, remove unused/legacy model fronts
8bbeb2a: remove ESMF<8 conditional blocks and code
ae01a66: clean up error logging
6f7ea44: simplify error messaging if required component is not found