-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submodule pointer for NCEPLIBS-pyprodutil #51
Update submodule pointer for NCEPLIBS-pyprodutil #51
Conversation
@climbfuji, these changes were committed to NEMS already: 16e1b94. Please let me know otherwise. |
Sorry, this is so confusing. I checked out develop from NEMS, and I see that these changes are in. But what about the submodule pointer for pyprodutil? Which hash do you want me to use there? If I check out develop in NCEPLIBS-pyprodutil, I have
but this hash is not the one that NEMS has at the moment. So at least I need to update that one (making this PR much more trivial, of course). @junwang-noaa |
d3ae3e1
to
4a59826
Compare
Ok, I think this is correct now. |
You are right... Somehow pyprodutil has two identical commits: 1fc711dc021f08f5d1eda2f4b5108af43ae33ef7 & ca171b95095db4fcd0fc7b01c23d073d90becd99 |
Ok - the one I have now (ca171b9) is the head of develop. |
Actually I thought we only make s2 related code changes in ufs-weather-model side. Anyway it's good if we update ufs-weather-model to the latest develop of prod-util. So now after we finish all the RT, we can ask Minsuk to commit. |
I think we can merge this one because this was tested previously: #47. As mentioned above, pyprodutil 1fc711d (one that NEMS is currently pointing to) & ca171b9 (head of develop) are identical. @junwang-noaa @climbfuji please let me know. |
Update submodule pointer for NCEPLIBS-pyprodutil (NOAA-EMC#51)
This PR only updates the submodule pointer for NCEPLIBS-pyprodutil to point to the current head of the develop branch:
Associated PRs:
NOAA-EMC/GFDL_atmos_cubed_sphere#17
NCAR/ccpp-framework#283
NCAR/ccpp-physics#436
NOAA-EMC/fv3atm#98
ufs-community/ufs-weather-model#102
For regression testing information, see ufs-community/ufs-weather-model#102.