-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression test updates: global_4dvar bug fix, oom fix, enhance error checking #532
Regression test updates: global_4dvar bug fix, oom fix, enhance error checking #532
Conversation
Below are ctest results on various platforms WCOSS2 (Dogwood)
The
The
Neither of these are fatal failures. Orion
The
This is not a fatal failure. Hera
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are all look good.
I made two minor comment on adjusting indentation to make code reading easier.
Rerun
Commit correction at b6c56f2 |
@hu5970 , thanks! This is above and beyond responsiveness! |
Description
Regression tests using
develop
found that ctestglobal_4dvar
seg faulted during the lanczos solver execution ofgsi.x
. This was traced to the wronganavinfo
file being used in the test. During this investigation other issues were found with the regression tests.The Orion job configuration for
rrfs_3denvar_glbens
was insufficient. The job aborted with an OOM error. The Hera job configuration requested more resources. The Orion configuration was updated to be consistent with Hera.Error checking was enhanced in the regression test scripts. Log files are now retained if a ctest fails.
Fixes #531
Type of change
How Has This Been Tested?
The full suite of 9 ctests will be run run on Hera, Orion, and WCOSS2. Test results will be documented in this PR.
Checklist