-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jet Support #529
Comments
All GSI regression tests pass except the following due to time limits: global_4denvar, rtma, rrfs_3denvar_glbens. The global_enkf test failed as the sanl* files were not produced. The ENKF did run to completion, but copious warnings about missing data were reported. I'm going to investigate and determine if the data are indeed present and copied/linked in correctly. The ENKF did execute properly when running cycled tests. |
@RussTreadon-NOAA @CoryMartin-NOAA I ran the problematic global_enkf test on Hera where it is also failing as the sanl* files are not being generated (see the attached log). I will open another issue to track this. In the meantime, do you think I am OK to proceed with a PR to update Jet support? |
@DavidHuber-NOAA does that test fail for you on Hera with develop? If so, I see no reason why it should hold up fixing Jet support. |
@CoryMartin-NOAA Yes, it did, but it was fixed with #532. The test now runs successfully on both Hera and Jet. |
Ok great, then it sounds like it is fine to proceed with a PR whenever you're ready |
@CoryMartin-NOAA I opened it on Friday actually (#537). By the way, if you have Jet support, I would appreciate the review. |
@DavidHuber-NOAA I do not unfortunately |
@CoryMartin-NOAA noted, thanks all the same. |
@HaidaoLin-NOAA , @guoqing-noaa , @hongli-wang - do any of you have time to review this Jet specific PR? |
@RussTreadon-NOAA I hope I can help but I am not familiar with the Jet HPC environment. |
@hongli-wang , got it. I'm in the same boat. It's preferable to find a peer reviewer who is familiar with Jet. |
@RussTreadon-NOAA I can give it a try when Jet is back from today's maintenance. |
Thank you @guoqing-noaa very much. I'll add you as a reviewer to PR #537. |
@RussTreadon-NOAA <https://github.com/RussTreadon-NOAA> I am sorry, I wish
I could help, but I am not familiar with the Jet environment.
…On Tue, Feb 21, 2023 at 9:19 AM RussTreadon-NOAA ***@***.***> wrote:
@HaidaoLin-NOAA <https://github.com/HaidaoLin-NOAA> , @guoqing-noaa
<https://github.com/guoqing-noaa> , @hongli-wang
<https://github.com/hongli-wang> - do any of you have time to review this
Jet specific PR?
—
Reply to this email directly, view it on GitHub
<#529 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APGIPWGRT4JR5DNEN5VUDODWYTTINANCNFSM6AAAAAAUUD45OM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
OK. Thank you @HaidaoLin-NOAA for letting us know. |
Jet has had hpc-stack installed in a new location and needs its module file updated to reflect that. Additionally, the new regression test data has been placed on Jet so the regression test scripts should also be updated and the RTs run to verify the system.
The text was updated successfully, but these errors were encountered: