-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save basic stats in csv at each cycle #1040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumevernieres
added
hera-GW-RT
Queue for automated testing with global-workflow on Hera
orion-GW-RT
Queue for automated testing with global-workflow on Orion
labels
Apr 12, 2024
emcbot
added
hera-GW-RT-Running
Automated testing with global-workflow running on Hera
orion-GW-RT-Running
Automated testing with global-workflow running on Orion
and removed
hera-GW-RT
Queue for automated testing with global-workflow on Hera
orion-GW-RT
Queue for automated testing with global-workflow on Orion
labels
Apr 12, 2024
Automated Global-Workflow GDASApp Testing Results:
|
emcbot
added
orion-GW-RT-Failed
Automated testing with global-workflow failed on Orion
and removed
orion-GW-RT-Running
Automated testing with global-workflow running on Orion
labels
Apr 12, 2024
Automated Global-Workflow GDASApp Testing Results:
|
emcbot
added
hera-GW-RT-Failed
Automated testing with global-workflow failed on Hera
and removed
hera-GW-RT-Running
Automated testing with global-workflow running on Hera
labels
Apr 12, 2024
guillaumevernieres
requested review from
AndrewEichmann-NOAA,
CoryMartin-NOAA,
danholdaway and
apchoiCMD
April 15, 2024 14:01
CoryMartin-NOAA
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think things will need cleaned up for "ops" but fine for current purpose.
danholdaway
added a commit
that referenced
this pull request
Apr 17, 2024
* upstream/develop: Get SOCA vrfy job working on Hera again (#1045) Get test data from a staged location on supported HPC Part Deux (#1052) Prepare observations for snow DA updates to the ensemble members (#998) Save basic stats in csv at each cycle (#1040) Fix bug for datetime in GHRSST Ioda Converter (#1027)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hera-GW-RT-Failed
Automated testing with global-workflow failed on Hera
orion-GW-RT-Failed
Automated testing with global-workflow failed on Orion
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work done
Computes basic stats (count, bias and rmse of omb's and oma's) for different ocean basins, this assumes the obs were flagged with the ocean mask from
RECCAP2_region_masks_all_v20221025.nc
.Work left to do
We're not flagging the obs currently, so that code will do nothing until we update the prep ocean obs yaml to point to
RECCAP2_region_masks_all_v20221025.nc
(it's been copied to the soca fix dir on hera and orion). To have the obs flagged in develop will require the ioda converters to not fail if theRECCAP2_region_masks_all_v20221025
isn't found.