Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug for datetime in GHRSST Ioda Converter #1027

Merged
merged 10 commits into from
Apr 15, 2024
Merged

Fix bug for datetime in GHRSST Ioda Converter #1027

merged 10 commits into from
Apr 15, 2024

Conversation

apchoiCMD
Copy link
Collaborator

@apchoiCMD apchoiCMD commented Apr 5, 2024 •
edited
Loading

@apchoiCMD apchoiCMD marked this pull request as draft April 5, 2024 18:38
@apchoiCMD apchoiCMD marked this pull request as ready for review April 5, 2024 18:51
@apchoiCMD apchoiCMD closed this Apr 11, 2024
@guillaumevernieres
Copy link
Contributor

I assume this was closed by mistake @apchoiCMD ?

@apchoiCMD
Copy link
Collaborator Author

I assume this was closed by mistake @apchoiCMD ?

Oh, thanks- I don't even know it is closed.

guillaumevernieres
guillaumevernieres reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you fixed the core of the issue, thanks @apchoiCMD ! But is the superobing still OK?

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 12, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 12, 2024
@emcbot
Copy link

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Apr 12 17:17:19 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Apr 12 17:17:39 CDT 2024
Build: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1027/global-workflow/sorc/log.build

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 12, 2024
@emcbot
Copy link

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Apr 12 22:34:26 UTC 2024 on hfe07
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Apr 12 22:34:36 UTC 2024
Tests: 81% tests passed, 10 tests failed out of 53
	1742 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1763 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1775 - test_gdasapp_atm_jjob_var_init (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1027/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Apr 12, 2024
@emcbot
Copy link

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Apr 12 22:34:26 UTC 2024 on hfe07
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Apr 12 22:34:36 UTC 2024
Tests: 81% tests passed, 10 tests failed out of 53
	1742 - test_gdasapp_fv3jedi_fv3inc (Failed)
	1763 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1775 - test_gdasapp_atm_jjob_var_init (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1027/global-workflow/sorc/gdas.cd/build/log.ctest

Build: SUCCESS
Build: Completed at Fri Apr 12 23:23:08 UTC 2024

Tests: Failed
Tests: Failed at Fri Apr 12 23:47:36 UTC 2024
Tests: 91% tests passed, 5 tests failed out of 53
1742 - test_gdasapp_fv3jedi_fv3inc (Failed)
1763 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
1776 - test_gdasapp_atm_jjob_var_run (Failed)
1777 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1027/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot
Copy link

emcbot commented Apr 12, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Fri Apr 12 17:17:19 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Apr 12 17:17:39 CDT 2024
Build: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1027/global-workflow/sorc/log.build

Build: SUCCESS
Build: Completed at Fri Apr 12 18:10:14 CDT 2024

Tests: Failed
Tests: Failed at Fri Apr 12 18:52:01 CDT 2024
Tests: 94% tests passed, 3 tests failed out of 53
1777 - test_gdasapp_atm_jjob_var_run (Failed)
1778 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1027/global-workflow/sorc/gdas.cd/build/log.ctest

guillaumevernieres
guillaumevernieres approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @apchoiCMD . I'm going to merge this, along with the last analysis that you shared, the stats from @KatherineLukens-NOAA 's runs seems to indicate that what you did is correct.

@guillaumevernieres guillaumevernieres merged commit 6f7bd18 into develop Apr 15, 2024
1 of 5 checks passed
@guillaumevernieres guillaumevernieres deleted the bugfix/ghrsst_datetime_cycle branch April 15, 2024 21:28
danholdaway added a commit that referenced this pull request Apr 17, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
76c7851 
* upstream/develop:
  Get SOCA vrfy job working on Hera again (#1045)
  Get test data from a staged location on supported HPC Part Deux (#1052)
  Prepare observations for snow DA updates to the ensemble members (#998)
  Save basic stats in csv at each cycle (#1040)
  Fix bug for datetime in GHRSST Ioda Converter (#1027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

@KatherineLukens-NOAA KatherineLukens-NOAA Awaiting requested review from KatherineLukens-NOAA

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GHRSST converter is not working properly
4 participants
@apchoiCMD @guillaumevernieres @emcbot @AndrewEichmann-NOAA