Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable quiet mode for markdown link checker #385

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented May 5, 2024

Description

Enables the 'use-quiet-mode' setting in the markdown link checker to only show broken links

Fixes #262

@sjvrijn sjvrijn force-pushed the 262-reduce-link-checker-verbosity branch 2 times, most recently from e5577e9 to 2c2e446 Compare May 6, 2024 09:10
@Cmurilochem
Copy link

Hi @sjvrijn. I will have some time on Friday to have a look at it. Sorry for the late feedback.

Copy link

@Cmurilochem Cmurilochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sjvrijn. As promised, I tested it locally with act and its works as expected. Good job!

I will approve it. But one question: Wouldn't it also be convenient to silent the markdown link checker here ?

This is up to up!

Thanks once again,
Best,
Carlos

@sjvrijn sjvrijn force-pushed the 262-reduce-link-checker-verbosity branch from 2c2e446 to df96ae2 Compare August 13, 2024 12:49
@sjvrijn
Copy link
Contributor Author

sjvrijn commented Aug 13, 2024

@Cmurilochem Good point, thanks for noticing!

@sjvrijn sjvrijn merged commit df96ae2 into main Aug 13, 2024
16 checks passed
@sjvrijn sjvrijn deleted the 262-reduce-link-checker-verbosity branch August 13, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make link checker less verbose
2 participants