Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.1.1 #32

Merged
merged 10 commits into from
Dec 18, 2023
Merged

0.1.1 #32

merged 10 commits into from
Dec 18, 2023

Conversation

sigmafelix
Copy link
Collaborator

  • More improvements in subsetting input datasets out of scomps-native processing functions: improved generalizability (despite necessitating tests) (i.e., argument grid_ref is dropped)
  • Class detection function
  • distribute_process_multirasters update
  • Documentation improvement

sigmafelix and others added 4 commits December 1, 2023 08:03
@sigmafelix
0.1.1 dev
868641c 
undefined
@sigmafelix
Small dispatcher update
e838b38
@sigmafelix
0.1.1
dd2cffd 
- Major changes
- grid_ref arguments are dropped in distribute_*
- detect_class is added
- Documentation was revised accordingly
@sigmafelix
0.1.1 hotfix
7c0870f 
- Remnants of dev codes were removed
- distribute*multirasters is added
- Argument class detection is implemented
@sigmafelix sigmafelix added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 15, 2023
@sigmafelix sigmafelix self-assigned this Dec 15, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 15, 2023 •
edited
Loading

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (7e3e027) 84.09% compared to head (49d1e88) 91.93%.
Report is 1 commits behind head on main.

Files Patch % Lines
R/scale_process.R 71.28% 29 Missing ⚠️
R/processing.R 90.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   84.09%   91.93%   +7.84%     
==========================================
  Files           7        7              
  Lines         503      583      +80     
==========================================
+ Hits          423      536     +113     
+ Misses         80       47      -33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sigmafelix and others added 6 commits December 15, 2023 17:34
@sigmafelix
Test fix
57a3e5e 
- check_bbox no longer accepts numeric reference
- multiraster test
@sigmafelix
0.1.1 update
e74bf59 
- kernel extraction is fully implemented
- S4 implicit list embedding error fix is pending
@sigmafelix
0.1.1 update
46c1639
@sigmafelix
Figured out extract_with_buffer_kernel errors
0e3727a 
- func argument should be explicitly declared (which accepts weights)
- Local test passing confirmed
@sigmafelix
Test diff cov fix
44de531 
- Multirasters tests are not detected by codecov?
@sigmafelix
0.1.1 error fix attempt
49d1e88 
- sedc calc suddenly failed;
- README.md edited
@sigmafelix sigmafelix merged commit 0fb9d0b into main Dec 18, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sigmafelix sigmafelix

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sigmafelix