0.2.0 dev #83
Merged
0.2.0 dev #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…associated unit tests
- To read shp files only
…\n - tests for retaining geometry
… calc_merra2, calc_gridet, calc_terraclimate
- To make calc_tri, calc_nlcd, calc_sedac_population abide by the protocol discussed in #68
- Now process_aqs supports three options - "full": locations * time regardless of attributes are available - "sparse": location-time pairs with available attributes - "location" unique locations existing the full input data - calc_worker gets match_arg() for time_type argument - Reflowing calc_nlcd
Mm manuscript 0425
- Significant changes - Due to bug fix of process_modis_swath, previous calculations are invalidated and should be rerun - Dropped doParallel and foreach dependency: future and future.apply in place - Bug fix - Tests on Date class is removed or replaced with POSIXt - HMS: empty/missing polygon error due to date sequence generator setting (i.e., sub_hyphen=TRUE) - calc_terraclimate: promise before evaluation error due to introducing geom argument - process_modis_swath: empty subdataset processing, clarified documentation on setting subdataset argument - process_modis_warp: first-phase mosaicking is done with stars::st_mosaic - Most calc_* functions for yearly updated raw data: explicit integer assignment complying to calc_check_time logic - Refactoring #75 - Etc. - Edited calculate_covariates tests - Edited calc_gmted for succinct field names - Edited process_gmted for the raw data compatibility - File name change of nei test data (...17.csv -> ...2017.csv) - Styling roxygen2 and elaborating documentation
- Revised swath function: all NaN layers get corner pixels to retain layers in multi-layer SpatRaster - Refactored calc_modis_par: try statement, error case treatment - calc_modis_daily: time field is assigned
- us_main in calc_nlcd is removed
- Logic for available date filtering by number of files is fixed
- Due to the deprecation of `directory_to_download` argument in download functions
- All tests passed locally
- writeLines to cat
- Koppen-Geiger refers to the direct file link - check_url_status: added 206 as a valid value since Koppen-Geiger S3 link only sends 206 Partial Content - AQS test: pick only one link - GET to HEAD for http tests
- 🤷🏻♂️ local tests passed
- extract_urls: added trimws to remove leading blanks - workflow yaml to cat all error messages
- setup-r-dependencies error
- pkgdown.yaml: test coverage html - color code for coverage rate: green/orange to green/yellow
- pkgdown: coverage inclusion test (2nd try) - nhdplusTools memoisation led to fail in GH Action: temporarily excluding from code coverage - rollback calc_lagged tests
- yaml - setup-r: use-public-rspm - calc_lagged: date alignment test logic fix
Open
- process_aqs: cases with multiple event types are handled - Documentation is revised to describe the event processing
- logic fix: from now `date` cannot be NULL. Records will be filtered with a date sequence generated from `date`.
- download_koppen_geiger: dropped overspecified file removal that cannot be tested - download_remove_zips: merging unlink() into the function, removed bare unlink()s in functions
- download_aqs: vapply to sapply - download_remove_zips tests - download_remove_zips documentation edited
- Non-testable lines in download_cropscape get nocov
mitchellmanware
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exactextractrandterrabased functions; the latter is slower but consumes less memory) and multicore mode by argumentnthreadsinst/extdata/nlcd_classes.csvfix: missing category is added (Perennial Ice/Snow)"Included"onlycheck_url_status: HTTP 200 and 206 are accepteddownload_koppen_geigertests: GET (actual download) to HEAD by accepting 206 and tracing the file originprocess_ecoregionwill return a fixed polygon around Tukey's Bridge in Portland, ME (see below; the red dot represents an AQS PM2.5 site)