Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.2 #28

Merged
merged 11 commits into from
Feb 29, 2024
Merged

0.1.2 #28

merged 11 commits into from
Feb 29, 2024

Conversation

mitchellmanware
Copy link
Collaborator

  • Minor updates for path = NULL and text messages
  • download_geos_cf_data -> download_geos_data
  • Fix "Errors when temporal ranges invalid." unit tests
    • Using collection = instead of variables = and vice versa caused tests to fail, but did not trigger the 404 URL response error
  • Unit tests for download support functions
  • Unit test for expected errors in manipulate_spacetime and calculate_covariates
  • Unit test for live download of HMS data to run download_sink(), download_run(), download_unzip(), and download_remove_zips
  • Remove the if(remove) trigger in download_gmted_data() and download_ecoregion_data() (see New tests #25)

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (dd4e871) to head (00b77ba).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   96.21%   98.10%   +1.88%     
==========================================
  Files           6        6              
  Lines        3227     3226       -1     
==========================================
+ Hits         3105     3165      +60     
+ Misses        122       61      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eva0marques eva0marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Collaborator

@sigmafelix sigmafelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for the hard work.

@mitchellmanware mitchellmanware merged commit 8364983 into main Feb 29, 2024
9 checks passed
@mitchellmanware mitchellmanware deleted the mm-defaults-0226 branch March 1, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants