Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

any::rstac in pkgdown workflow #121

Merged
merged 1 commit into from
Aug 14, 2024
Merged

any::rstac in pkgdown workflow #121

merged 1 commit into from
Aug 14, 2024

Conversation

mitchellmanware
Copy link
Collaborator

rstac dependency in the test coverage portion of pkgdown deployment workflow

Copy link
Collaborator

@sigmafelix sigmafelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitchellmanware I think rstac is required for OpenLandMap data download. Since we put _olm functions inactive, I don't think we need to install rstac at the moment. Did you find any errors in pkgdown workflow related to rstac?

@mitchellmanware
Copy link
Collaborator Author

@sigmafelix

The pkgdown deployment when pull into the main branch is failing due to missing rstac dependency in the test-covr job.
https://github.com/NIEHS/amadeus/actions/runs/10375868561/job/28726479014

The same issue was occurring for the test-coverage workflow in the 1.0.3 PR last week. First image shows run without any::rstac in the .github/workflows/test-coverage.yml and the second with it included (although tests still failed due to the calc_lagged issue, the failure is no longer due to rstac).
Screenshot 2024-08-14 at 8 35 28 AM (2)

Screenshot 2024-08-14 at 8 35 31 AM (2)

I know we inactivated the olm functions from the main code base, but as they are still checked by the test-download_olm.R, test-process_olm.R and test-list_stac_files.R, it needs to be included for test-coverage and pkgdown workflows

@sigmafelix
Copy link
Collaborator

Got it. I'll approve the PR. Thanks.

@mitchellmanware mitchellmanware merged commit 969f8b2 into main Aug 14, 2024
10 checks passed
@mitchellmanware mitchellmanware deleted the rstac-0813 branch August 16, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants