Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate spatial/spatiotemporal functions #23

Closed
ericbair-sciome opened this issue Nov 12, 2023 · 1 comment · Fixed by #44
Closed

Consolidate spatial/spatiotemporal functions #23

ericbair-sciome opened this issue Nov 12, 2023 · 1 comment · Fixed by #44
Assignees
@ericbair-sciome
Labels
enhancement New feature or request version 1.0 Features that should be included in the initial PrestoGP release

Comments

@ericbair-sciome
Copy link
Collaborator

Initially the package was written to allow only spatial and spatiotemporal models with separate functions for each. We decided to allow for more generalized locs/scale parameters and use only set of functions for the general case. This change has been made for the multivariate Vecchia model. However, all other models still have separate spatial and spatiotemporal versions. We need to combine the spatial and spatiotemporal functions into a single version that takes a "scaling" parameter.
@ericbair-sciome ericbair-sciome added enhancement New feature or request version 1.0 Features that should be included in the initial PrestoGP release labels Nov 12, 2023
@ericbair-sciome ericbair-sciome self-assigned this Dec 19, 2023
sciome-bot pushed a commit that referenced this issue Jan 10, 2024
@shail-choksi
Pull request #23: Auto-formatting changes
9090112 
* commit '82eab4427a8fe3b65d2d7d212b394c7feac840ce':
  Auto-formatting changes
@ericbair-sciome ericbair-sciome linked a pull request Jan 10, 2024 that will close this issue
Sciome Update 1/10/2024 #44
Merged
@ericbair-sciome
Copy link
Collaborator Author

This is fixed in the latest release. Only one version of the univariate models (both Vecchia and full) now exists. And both types of models can handle any number of locs with any number of scaling parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericbair-sciome ericbair-sciome

Labels
enhancement New feature or request version 1.0 Features that should be included in the initial PrestoGP release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sciome Update 1/10/2024 NIEHS/PrestoGP
1 participant
@ericbair-sciome