-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new history output dimension patch age x fuel size class #712
Conversation
… to get fuel amount by new dim
A simple jupyter notebook looking at short, 1 year f10 grid case is available here: https://github.com/glemieux/fates-jupyter/blob/master/california/new-dimension-age_by_fuel.ipynb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glemieux this looks great. i also ran a case with it and output looks reasonable. thanks for adding the xarray unrolling function in NCAR/ctsm_python_gallery#35 as well!
looks good @glemieux , couldn't find any issues |
Thanks @rgknox. I'll run the regression tests today. |
Regression tests are all PASS, except for the baseline comparison, which is expected. That said, during baseline comparison it appears that |
Reran the
Note that the |
This PR adds a new patch age x fuel size class multiplexed output dimension and includes and new history output variable
FUEL_AMOUNT_AGEFUEL
that utilizes this dimension.Description:
This request came out of the California LDRD meeting where the desire to be able to track the per fuel class accumulation since a given disturbance. The corresponding CTSM side PR is ESCOMP/CTSM#1220.
A PR to ctsm_py has been created to update to the the fates_xarray_funcs module to include an
fates_levagefuel
expansion function: NCAR/ctsm_python_gallery#35Collaborators:
@ckoven @JessicaNeedham @rgknox
Expectation of Answer Changes:
No answer changes expected
Checklist:
Test Results:
TBD
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: