Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new history output dimension patch age x fuel size class #712

Merged
merged 5 commits into from
Dec 14, 2020

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Nov 19, 2020

This PR adds a new patch age x fuel size class multiplexed output dimension and includes and new history output variable FUEL_AMOUNT_AGEFUEL that utilizes this dimension.

Description:

This request came out of the California LDRD meeting where the desire to be able to track the per fuel class accumulation since a given disturbance. The corresponding CTSM side PR is ESCOMP/CTSM#1220.

A PR to ctsm_py has been created to update to the the fates_xarray_funcs module to include an fates_levagefuel expansion function: NCAR/ctsm_python_gallery#35

Collaborators:

@ckoven @JessicaNeedham @rgknox

Expectation of Answer Changes:

No answer changes expected

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

TBD

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux
Copy link
Contributor Author

glemieux commented Nov 19, 2020

A simple jupyter notebook looking at short, 1 year f10 grid case is available here: https://github.com/glemieux/fates-jupyter/blob/master/california/new-dimension-age_by_fuel.ipynb

Copy link
Contributor

@ckoven ckoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glemieux this looks great. i also ran a case with it and output looks reasonable. thanks for adding the xarray unrolling function in NCAR/ctsm_python_gallery#35 as well!

@rgknox
Copy link
Contributor

rgknox commented Nov 24, 2020

looks good @glemieux , couldn't find any issues

@rgknox rgknox self-requested a review November 24, 2020 17:26
@glemieux
Copy link
Contributor Author

Thanks @rgknox. I'll run the regression tests today.

@rgknox rgknox self-assigned this Nov 30, 2020
@glemieux
Copy link
Contributor Author

glemieux commented Nov 30, 2020

Regression tests are all PASS, except for the baseline comparison, which is expected. That said, during baseline comparison it appears that cprnc is crashing during the DIFF due to the new dimension. I'm not sure if this is expected behavior for cprnc; I'll look into it.

@glemieux
Copy link
Contributor Author

glemieux commented Dec 7, 2020

Reran the cprnc tool from the cime fix in PR ESMCI/cime#3663. All expected pass B4B:

/glade/u/home/glemieux/scratch/clmed-tests/basegen.fates-sci.1.43.2_api.14.2.0-fates_main_api_14.0.0-C0392347e-F86e8f11c

Note that the cs.status script pulls from the TestStatus log and as such will not correctly report the manual run cprnc tests.

@rgknox rgknox merged commit 5534a94 into NGEET:master Dec 14, 2020
@glemieux glemieux deleted the newdim-patchage_by_fuelclass branch March 21, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants