cprnc: Fix integer single-variable analysis #3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in ESMCI#3531 introduced an error when doing single-variable analysis on an integer variable, using an integer format where it should now be using a real format. This commit fixes this issue. Resolves ESMCI#3661
|
@jedwards4b @jgfouca @fischer-ncar - the bug fixed by this doesn't show up often, but it would still be good to update any maintained versions of cprnc (on cheyenne, izumi, etc.) once this is merged. This bug will show up when an integer variable has been added or removed from an output netcdf file, relative to the baseline. |
|
@fischer-ncar would you be able to update the cprnc builds on cheyenne & izumi once this is merged? I have lost track of the latest process for doing so (e.g., any special build flags needed). |
jedwards4b
approved these changes
Aug 12, 2020
jedwards4b
pushed a commit
to jedwards4b/cime
that referenced
this pull request
Aug 12, 2020
Add support for grids using r0125_oRRS18to6v3 Following grids and their pg2 counterparts are added: ne30_r0125_oRRS18to6v3 and ne120_r0125_oRRS18to6v3. The mapfiles between the components are also populated. [BFB]
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix single-variable integer output in cprnc.
The changes in #3531 introduced an error when doing
single-variable analysis on an integer variable, using an integer format
where it should now be using a real format. This PR fixes this issue.
Test suite: cprnc's run_tests
All tests produce the same output as master.
I have added a new test that fails on master but passes now.
Test baseline: 7e26559
Test namelist changes: none
Test status: bit for bit
Fixes #3661
User interface changes?: N
Update gh-pages html (Y/N)?: N
Code review: @jedwards4b