Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dtc/develop from develop and other updates 2020/04/09 #38

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 9, 2020

This PR contains:

Associated PRs:
NCAR/GFDL_atmos_cubed_sphere#11
NCAR/ccpp-framework#281
NCAR/ccpp-physics#432 (contains NCAR/ccpp-physics#424)
NCAR/fv3atm#40
https://github.com/NCAR/ufs-weather-model/pull/38/files

For regression testing information, see below.

climbfuji and others added 6 commits March 27, 2020 15:22
…physics (ufs-community#91)

* Update .gitmodules and submodule pointer for fv3atm for code review and testing

* Regression test logs for hera.intel using rt.sh

* Regression test logs for wcoss_dell_p3 using NEMSCompsetRun

* Update submodule pointer for FV3 after renaming S2S suite suite_FV3_GFS_2017_coupled_satmedmf.xml to suite_FV3_GFS_2017_satmedmf_coupled.xml

* Regression test logs for wcoss_dell_p3 using rt.sh; regression test logs for wcoss_cray using rt.sh and NEMSCompsetRun

* Regression test logs for hera.intel using NEMSCompsetRun

* Revert change to .gitmodules and update submodule pointer for fv3atm
…AA/ufs-weather-model into update_dtc_develop_from_emc_develop_and_other_updates_20200409
@climbfuji
Copy link
Collaborator Author

Note on regression testing

Note that the regional blending updates from EMC changed the results for the following tests:

fv3_regional_control
fv3_regional_control_repro
fv3_regional_control_ccpp
fv3_regional_restart
fv3_regional_restart_repro
fv3_regional_restart_ccpp

On hera.intel, these updates baselines were synced from the official EMC baseline to our DTC baseline, in order to run the full regression tests against the DTC baseline and knowing that no results changed from our side.

On cheyenne.intel, the new input files were copied from hera and new baselines generated for just these tests (nothing else) and merged with the existing baseline to create the new baseline. Then, the full regression tests against the updated baseline were run.

On cheyenne.gnu, these tests are not executed and the regression tests were run against an rsync-ed copy of the previous baseline (i.e. just a new date tag). However, the new input files for the regional tests were also copied into the baseline in order to enable those tests in the future.

@climbfuji
Copy link
Collaborator Author

Regression testing on cheyenne.gnu against existing baseline (with new date tag): all tests pass.

rt_cheyenne_gnu.log

@climbfuji climbfuji marked this pull request as ready for review April 10, 2020 02:31
@ligiabernardet
Copy link
Collaborator

I did not inspect the code in detail, but I looked overall at what is involved in this update. All looks good to me, and I am glad to see innovations in CCPP-F and CCPP-P making their way to master.

@climbfuji
Copy link
Collaborator Author

Regression testing on hera.intel against new baseline (which is a copy of our old baseline, just the tests with changes as listed above are copied over from the new EMC baseline): all tests pass. I had to rerun two tests because of file system issues on hera.

rt_hera_intel.log
rt_hera_intel_fail_test.log
rt_hera_intel_rerun.log

@climbfuji
Copy link
Collaborator Author

climbfuji commented Apr 10, 2020

Regression testing on cheyenne.intel against new baseline: post-commit update: all tests passed.

rt_cheyenne_intel.log

@climbfuji
Copy link
Collaborator Author

I merged all these PRs without further approval to prepare our commit to master (after merging in the IN/CCN MG changes in another round of commits).

@climbfuji climbfuji merged commit e447123 into NCAR:dtc/develop Apr 10, 2020
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Sep 24, 2020
…00826

Update submodule pointer for fv3atm 2020/08/26
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Apr 3, 2023
… update ufs-community#1673 (ufs-community#1633)

* Add 4 new quilting restart tests

* Remove tests/qr.conf

* Fix fv3_conf/regional_run.IN script to correctly copy restart files from dependent directory

* Clean up Thompson table files (NCAR#38)

* update control_qr_p8 control_restart_qr_p8

* Disable cpld_control_ciceC_p8 and cpld_control_c192_p8/cpld_restart_c192_p8 on Gaea

* Update FV3 and WW3

Co-authored-by: Dusan Jovic <Dusan.Jovic@noaa.gov>
Co-authored-by: Jessica Meixner <Jessica.Meixner@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants