Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dtc/develop from EMC develop and collect updates 2019/12/05 #11

Merged
merged 8 commits into from
Dec 9, 2019
Merged

Update dtc/develop from EMC develop and collect updates 2019/12/05 #11

merged 8 commits into from
Dec 9, 2019

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 6, 2019 •
edited
Loading

This PR updates ufs-weather-model dtc/develop with the latest changes from EMC and other updates:

@climbfuji climbfuji mentioned this pull request Dec 6, 2019
Merged
@climbfuji climbfuji force-pushed the update_dtc_develop_from_emc_develop_and_collect_updates_20191205 branch from 0b307a5 to 2c913a4 Compare December 8, 2019 13:23
@climbfuji climbfuji force-pushed the update_dtc_develop_from_emc_develop_and_collect_updates_20191205 branch from a115bbf to b95c95a Compare December 8, 2019 13:42
This was referenced Dec 8, 2019
Merged
Merged
@climbfuji
Copy link
Collaborator Author

Associated PRs:

NCAR/ccpp-physics#366
NCAR/fv3atm#15
#11

See below for regression testing.

@climbfuji
Copy link
Collaborator Author

climbfuji commented Dec 8, 2019 •
edited
Loading

Regression testing against official EMC baseline using rt.conf on hera/intel: the following tests fail (OK):

fv3_gfdlmprad_noahmp prod (because of NCAR/fv3atm#14)
fv3_gfdlmprad_noahmp repro (because of NCAR/fv3atm#14)
fv3_gfdlmprad repro (newly created as part of #9)
fv3_ccpp_gfdlmprad repro (newly created as part of #9)
fv3_ccpp_gfdlmprad_noahmp repro (because of NCAR/ccpp-physics#365)
fv3_ccpp_gsd repro (because of updates to GSD suite in #8)
fv3_ccpp_gfdlmprad prod (newly created as part of #9)
fv3_ccpp_wrtGauss_nemsio_c768 prod (because of updates in #9)
fv3_ccpp_gfdlmprad_noahmp prod (because of NCAR/ccpp-physics#365)
fv3_ccpp_gsd prod (because of updates to GSD suite in #8)

rt_full_against_emc_baseline.log

@climbfuji climbfuji marked this pull request as ready for review December 8, 2019 14:07
@climbfuji
Copy link
Collaborator Author

Regression testing against DTC baseline using rt.conf on hera/intel: the following tests fail (OK):

fv3_gfdlmprad_noahmp prod (because of NCAR/fv3atm#14)
fv3_gfdlmprad_32bit_post prod (because of NOAA-EMC/fv3atm#14)
fv3_gfdlmprad_noahmp repro (because of NCAR/fv3atm#14)
fv3_gfdlmprad_32bit_post repro (because of NOAA-EMC/fv3atm#14)
fv3_ccpp_gfdlmprad_noahmp repro (because of NCAR/ccpp-physics#365)
fv3_ccpp_gfdlmprad_32bit_post repro (because of NOAA-EMC/fv3atm#14)
fv3_ccpp_gfdlmprad_noahmp prod (because of NCAR/ccpp-physics#365)
fv3_ccpp_gfdlmprad_32bit_post prod (because of NOAA-EMC/fv3atm#14)

rt_full_against_dtc_baseline.log

@climbfuji
Copy link
Collaborator Author

Regression tests using rt_ccpp_dtc.conf (create + verify) on hera/intel: all pass.

rt_ccpp_dtc_create.log
rt_ccpp_dtc_verify.log

@climbfuji
Copy link
Collaborator Author

Regression tests using rt_ccpp_gsd.conf (create + verify) on hera/intel: all pass.

rt_ccpp_gsd_verify.log
rt_ccpp_gsd_create.log

@climbfuji
Copy link
Collaborator Author

Regression tests using rt_ccpp_caps.conf (create + verify) on hera/intel: all pass.

rt_ccpp_caps_create.log
rt_ccpp_caps_verify.log

@climbfuji
Copy link
Collaborator Author

climbfuji commented Dec 8, 2019 •
edited
Loading

Regression tests using rt_ccpp_hafs.conf (create + verify) on hera/intel: all pass.

rt_ccpp_hafs_create.log
rt_ccpp_hafs_verify.log

@climbfuji
Copy link
Collaborator Author

climbfuji commented Dec 8, 2019 •
edited
Loading

Regression tests using rt.conf to create new DTC baseline and verify against it on hera/intel: all pass.

rt_full_create_new_dtc_baseline.log
rt_full_verify_against_new_dtc_baseline.log

@climbfuji
Copy link
Collaborator Author

These PRs are ready to merge.

grantfirl
grantfirl approved these changes Dec 9, 2019
View reviewed changes
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@climbfuji climbfuji merged commit bf05b97 into NCAR:dtc/develop Dec 9, 2019
@climbfuji climbfuji mentioned this pull request Dec 10, 2019
Closed
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Apr 3, 2020
@DomHeinzeller
Merge pull request NCAR#11 from climbfuji/gsd-dev-clouds_thompson-no-…
badba27 
…aero_dom

Update for "Changes in cloud/radiation interaction in GSD physics suite", non-aerosol-aware Thompson MP tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantfirl grantfirl grantfirl approved these changes

@llpcarson llpcarson Awaiting requested review from llpcarson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@climbfuji @grantfirl @junwang-noaa @panll @linlin-pan