ufs-dev PR#34 #82
Closed
ufs-dev PR#34 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bring in inst_pres_interface for AQM
…-EMC#613) * Hardcoded coarse terrain for moving nest with terrain_smoother=4 * Update HAFSv1 CCPP suites to use the unified ugwp scheme. * Update submodule upp. * Removed debug print statements for terrain_smoother * Fixed bug in calculation of nest halo weights identified by Biju Thomas in DDEBUG=ON builds. * Updated fix to moving nest weight calculations. * Use ind arrays for nest weight calculations. Ensures correct indexing. * Clean up for the fix of using ind arrays for moving-nest weight calculations (from @wramstrom). Co-authored-by: William Ramstrom <William.Ramstrom@noaa.gov>
…NOAA-EMC#618) * Use 32bit value for 'missing_value' and '_FillValue' attributes
…EMC#621) * Bug fix for cloud effective radius for convective clouds (HR1)
* Changes to typedefs for RRTMGP refactoring. Updates to prebuild and SDFs. * bugfix to save q state regardless of diagnostic flag, submodule update * optimizing massflux at cloud base based on P8 simulations, submodule update ccpp/physics * Added RRTMGP p8 coupled RT. * Move allocation of RRTMGP DDTs to init. * Removed deprecated SDFs Co-authored-by: Lisa Bengtsson <Lisa.Bengtsson@noaa.gov>
* Changes to typedefs for RRTMGP refactoring. Updates to prebuild and SDFs. * bugfix to save q state regardless of diagnostic flag, submodule update * optimizing massflux at cloud base based on P8 simulations, submodule update ccpp/physics * Added RRTMGP p8 coupled RT. * Move allocation of RRTMGP DDTs to init. * Removed deprecated SDFs Co-authored-by: Lisa Bengtsson <Lisa.Bengtsson@noaa.gov>
grantfirl
approved these changes
Feb 8, 2023
|
@dustinswales For some reason, it looks like this is missing some commits that have been put in the NOAA-EMC/fv3atm branch. Could you bring in the latest NOAA-EMC/fv3atm develop branch into your PR branch? |
…#622) * fix initialization for moving nest grid
* Six new winter wx diags added to output, accumulated fields added to restart file and changed nsradar_reset, radar_reset to something that makes more sense, that is, nsfullradar_diag and fullradar_diag. Also, added new namelist parameter to use new precip ice density with the NOAH LSM. Code changes to upp also made to include the new winter wx diags.
…nout' (NOAA-EMC#627) * Changed UGWP diagnostic variable declaration intents from 'out' to 'inout' * Updated UGWP diagnostic variable declaration intents in drag_suite.meta
|
@grantfirl Closing in favor of #84. I messed something up along the way... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to NOAA-EMC #619