Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule UPP and some HAFS moving-nesting related fixes #613

Merged
merged 21 commits into from
Jan 17, 2023

Conversation

BinLiu-NOAA
Copy link
Collaborator

@BinLiu-NOAA BinLiu-NOAA commented Dec 20, 2022

Description

  • Update submodule UPP to its latest develop branch, which is needed by HAFSv1.
  • Add the terrain_smoother namelist option of 4, with which the moving nest leading edge will use the topography interpolated from its parent coarse grid. Enabled and implemented by @wramstrom to fix the artificial gravity wave issues and model failures caused by the moving nest edge crossing steep topography.
  • Bug fix in calculation of moving-nest halo weights identified by @BijuThomas-NOAA in DDEBUG=ON builds (from @wramstrom).

Issue(s) addressed

Testing

Regression tests conducted at the ufs-weather-model level.

Dependencies

@BinLiu-NOAA BinLiu-NOAA marked this pull request as ready for review December 21, 2022 22:30
@BinLiu-NOAA BinLiu-NOAA changed the title Update submodule UPP to its latest develop branch Update submodule UPP and add the terrain_smoother namelist option of 4 to fix the artificial gravity wave issue for HAFS moving nest Jan 4, 2023
@BinLiu-NOAA BinLiu-NOAA changed the title Update submodule UPP and add the terrain_smoother namelist option of 4 to fix the artificial gravity wave issue for HAFS moving nest Update submodule UPP and some HAFS moving-nesting related fixes Jan 11, 2023
@jkbk2004
Copy link
Collaborator

@DusanJovic-NOAA @ChunxiZhang-NOAA ufs-community/ufs-weather-model#1544 build crash on hera with complains ccpp_static_api.F90.o Error 1 I am wondering if it could be new scheme added to the pr, unified_ugwp

@DusanJovic-NOAA
Copy link
Collaborator

I ran regional_debug on Hera, which uses -DAPP=ATM -DDEBUG=ON -D32BIT=ON build options, same as compile_012 job, and it compiled successfully.
See: /scratch1/NCEPDEV/stmp2/Dusan.Jovic/FV3_RT/rt_272929/compile_001

@ChunxiZhang-NOAA
Copy link
Contributor

That is interesting. I got the same error message as what Jong got on Hera when running ./rt.sh -k -n control_csawmg_debug > & rt.log &.

@ChunxiZhang-NOAA
Copy link
Contributor

I guess the error is only caused by csawmg related ccpp suite.

@DusanJovic-NOAA
Copy link
Collaborator

See: /scratch1/NCEPDEV/stmp2/Dusan.Jovic/FV3_RT/rt_115249

control_csawmg_debug test compiled and finished successfully.

@jkbk2004
Copy link
Collaborator

I am not sure if we are seeing similar issue as ufs-community/ufs-weather-model#1450, let me manually run on other machines.

@jkbk2004
Copy link
Collaborator

all the tests are done on ufs-community/ufs-weather-model#1544, please, go ahead to make final approvals

@jkbk2004
Copy link
Collaborator

@BinLiu-NOAA upp hash update in this pr, right?

@jkbk2004 jkbk2004 self-requested a review January 17, 2023 20:46
@jkbk2004 jkbk2004 merged commit 23bbfcd into NOAA-EMC:develop Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use coarse resolution parent topography for moving nest leading edge Update submodule FV3/upp for HAFSv1
6 participants