Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #44 - manifest_url for SIP labels #56

Merged
merged 3 commits into from
Apr 24, 2020
Merged

Resolve #44 - manifest_url for SIP labels #56

merged 3 commits into from
Apr 24, 2020

Conversation

nutjob4life
Copy link
Member

Summary

Test Data and/or Report

$ bin/test
Running tests at level 1
Running zope.testrunner.layer.UnitTests tests:
  Set up zope.testrunner.layer.UnitTests in 0.000 seconds.
  Running:
    3/15 (20.0%) test_logging_arguments (pds.aipgen.tests.test_utils.ArgumentTestCase)usage: 
                                                                                                          
  Ran 15 tests with 0 failures, 0 errors, 0 skipped in 0.046 seconds.
Tearing down left over layers:
  Tear down zope.testrunner.layer.UnitTests in 0.000 seconds.

Related Issues

  • (Future issue number) For when "they" realize that manifest_url maybe isn't the right idea 🤷‍♀️

nutjob4life and others added 3 commits April 23, 2020 17:35
-   Test case to expose the issue
-   New constant for SIP manifest locations
-   Slight PEP-8 cosmetic fix (spaces around `+`)
@jordanpadams jordanpadams merged commit bc6559f into master Apr 24, 2020
@jordanpadams jordanpadams deleted the i44 branch April 24, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIP label contains invalid manifest URL using file path
2 participants