Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIP label contains invalid manifest URL using file path #44

Closed
jordanpadams opened this issue Apr 23, 2020 · 3 comments · Fixed by #56
Closed

SIP label contains invalid manifest URL using file path #44

jordanpadams opened this issue Apr 23, 2020 · 3 comments · Fixed by #56
Assignees
@nutjob4life
Labels
bug Something isn't working
Milestone
PDS.15 (ends 2020...

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Apr 23, 2020 •
edited
Loading

Describe the bug

<manifest_checksum>ee7049f6cc8688ac75e93527fe293541</manifest_checksum>
<checksum_type>MD5</checksum_type>
<manifest_url>file:/home/jpadams/insight.spice_v4.0_sip_v1.0.tab</manifest_url> << ERROR <<
<aip_lidvid>urn:nasa:pds:system_bundle:product_aip:insight.spice_v4.0::1.0</aip_lidvid>
<aip_label_checksum>bb5f119d287d01823a3d84f72608c23d</aip_label_checksum>

ERROR above needs to be a URL and should never be a file path

NOTE: This should really be validated in the Schematron / Schema formation rules, but it is indicated as a String field
@jordanpadams jordanpadams added bug Something isn't working high labels Apr 23, 2020
@jordanpadams jordanpadams added this to the PDS.15 (ends 2020-04-22) milestone Apr 23, 2020
@nutjob4life
Copy link
Member

OK so it looks like I was trying to be anal retentive with

etree.SubElement(deep, prefix + 'manifest_url').text = 'file:' + os.path.abspath(manifestFile)

which is indeed a URL!

So should it just be manifestFile so it's a relative URI?

@jordanpadams
Copy link
Member Author

@nutjob4life great questions. pinged the NSSDCA folks. standby....

@jordanpadams
Copy link
Member Author

@nutjob4life lets use a default base URL of https://pds-gamma.jpl.nasa.gov/data/pds4/manifests/ for now

nutjob4life added a commit that referenced this issue Apr 23, 2020
@nutjob4life
Resolve #44 - manifest_url for SIP labels
bce766e 
-   Test case to expose the issue
-   New constant for SIP manifest locations
-   Slight PEP-8 cosmetic fix (spaces around `+`)
@nutjob4life nutjob4life mentioned this issue Apr 23, 2020
Merged
jordanpadams added a commit that referenced this issue Apr 24, 2020
@nutjob4life @jordanpadams
Resolve #44 - manifest_url for SIP labels (#56)
bc6559f 
* Resolve #44 - `manifest_url` for SIP labels

-   Test case to expose the issue
-   New constant for SIP manifest locations
-   Slight PEP-8 cosmetic fix (spaces around `+`)

* Update URL to pds.nasa.gov

* Update manifest URL to pds.nasa.gov

Co-authored-by: Jordan Padams <33492486+jordanpadams@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nutjob4life nutjob4life

Labels
bug Something isn't working
Projects
None yet
Milestone
PDS.15 (ends 2020-04-22)
Development

Successfully merging a pull request may close this issue.

Resolve #44 - manifest_url for SIP labels NASA-PDS/deep-archive
2 participants
@nutjob4life @jordanpadams