Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add users disable 2FA #646

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Add users disable 2FA #646

merged 2 commits into from
Oct 17, 2022

Conversation

antons-
Copy link
Contributor

@antons- antons- commented Aug 2, 2022

Adds support for the disable two factor authentication endpoint introduced in GitLab 15.2.

@antons-
Copy link
Contributor Author

antons- commented Aug 2, 2022

Regarding the failed Rubocop test - I wasn't sure on the best way to deal with this. Did we want to increase the line length limit?

@asedge
Copy link
Collaborator

asedge commented Aug 3, 2022

You could disable the cop, via comment, for that one line. Not sure how @NARKOZ would feel about updating the line length for the whole project.

@antons-
Copy link
Contributor Author

antons- commented Aug 15, 2022

Thanks @asedge for the suggestion. For now I have disabled the cop via comment, and now all the tests are passing.

I should point out that the max limit for the Layout/LineLength cop is 127 characters - whereas my change makes the line 128 characters (1 character over the limit).

@NARKOZ Let me know what you think.

@asedge asedge requested a review from NARKOZ October 6, 2022 12:57
Copy link
Collaborator

@asedge asedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve and leave it for a few days to see if @NARKOZ has any input. After that I'll merge it in and we'll deal with it later (if needed). Thanks so much for the contribution!

@asedge asedge merged commit 9e41329 into NARKOZ:master Oct 17, 2022
@asedge
Copy link
Collaborator

asedge commented Oct 17, 2022

Thank you for your contribution! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants