Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for inserting an item in a CSSList #545

Merged
merged 11 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
## x.y.z

### Added

- Add support for inserting an item in a CSS list (#545)
- Add a class diagram to the README (#482)
- Add support for the `dvh`, `lvh` and `svh` length units (#415)
- Add more tests (#449)
Expand Down
16 changes: 16 additions & 0 deletions src/CSSList/CSSList.php
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,22 @@ public function splice($iOffset, $iLength = null, $mReplacement = null)
array_splice($this->aContents, $iOffset, $iLength, $mReplacement);
}

/**
* Inserts an item in the CSS list before its sibling. If the desired sibling cannot be found,
* the item is appended at the end.
*
* @param RuleSet|CSSList|Import|Charset $item
* @param RuleSet|CSSList|Import|Charset $sibling
*/
public function insertBefore($item, $sibling): void
{
if (in_array($sibling, $this->aContents, true)) {
$this->replace($sibling, [$item, $sibling]);
} else {
$this->append($item);
}
}

/**
* Removes an item from the CSS list.
*
Expand Down
55 changes: 55 additions & 0 deletions tests/CSSList/DocumentTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,59 @@ public function setContentsReplacesContentsSetInPreviousCall(): void

self::assertSame($contents2, $this->subject->getContents());
}

/**
* @test
*/
public function insertContentBeforeInsertsContentBeforeSibbling()
{
$bogusOne = new DeclarationBlock();
$bogusOne->setSelectors('.bogus-one');
$bogusTwo = new DeclarationBlock();
$bogusTwo->setSelectors('.bogus-two');

$item = new DeclarationBlock();
$item->setSelectors('.item');

$sibling = new DeclarationBlock();
$sibling->setSelectors('.sibling');

$this->subject->setContents([$bogusOne, $sibling, $bogusTwo]);

self::assertCount(3, $this->subject->getContents());

$this->subject->insertBefore($item, $sibling);

self::assertCount(4, $this->subject->getContents());
self::assertSame([$bogusOne, $item, $sibling, $bogusTwo], $this->subject->getContents());
}

/**
* @test
*/
public function insertContentBeforeAppendsIfSibblingNotFound()
{
$bogusOne = new DeclarationBlock();
$bogusOne->setSelectors('.bogus-one');
$bogusTwo = new DeclarationBlock();
$bogusTwo->setSelectors('.bogus-two');

$item = new DeclarationBlock();
$item->setSelectors('.item');

$sibling = new DeclarationBlock();
$sibling->setSelectors('.sibling');

$orphan = new DeclarationBlock();
$orphan->setSelectors('.forever-alone');

$this->subject->setContents([$bogusOne, $sibling, $bogusTwo]);

self::assertCount(3, $this->subject->getContents());

$this->subject->insertBefore($item, $orphan);

self::assertCount(4, $this->subject->getContents());
self::assertSame([$bogusOne, $sibling, $bogusTwo, $item], $this->subject->getContents());
}
}