-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose rust as python extension #5
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 12 12
Branches 1 1
=========================================
Hits 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MusicalNinjaDad - I've reviewed your changes and they look great!
General suggestions:
- Consider adding explicit handling for edge cases in the fizzbuzz function to ensure robustness across all possible inputs.
- Review the naming convention for the PyO3 module to ensure clarity and alignment with Python package naming conventions.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
src/lib.rs
Outdated
fn fizzbuzz(num: i32) -> String { | ||
num.fizzbuzz() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (edge_case_not_handled): Consider handling edge cases for the fizzbuzz
function.
The current implementation directly calls num.fizzbuzz()
without checking for negative numbers or zero. It might be beneficial to define behavior for these cases to avoid unexpected results.
Rename to fizzbuzzpy & fizzbuzzo3 and expose fizzbuzzo3.fizzbuzz to python