Make LCD/SPI/USART units compatible to the Nuclei SDK #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsauthof
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the
nuclei-sdkinstead of the oldgd32vf103-sdkframework with PlatformIO, because the former superseded the latter.Nuclei is quite similar, but there are also some differences. Such as bug fixes but also changes in how the headers include each other.
Thus, I made the includes more specific such that it also compiles under the Nuclei SDK. These changes should even be backwards compatible, since those headers were present in the old SDK, as well.
While at it I also added support for line-feed (
\r), fixed a few warnings and replaced the LcdCmdData class with initializers lists to save some bytes in the data segment.Perhaps this makes the code also easier to maintain, since there is no need anymore to specify the correct size for the command block.
PS: Btw, I also locked at your
LcdFontsexample sub-directory and it looks that there are some files missing?I mean I don't find the location where e.g.
FreeMonoBold18pt7bis defined.And I also can't find the
fonts.hheader:LonganNanoTest/LcdFonts/src/fonts.cpp
Line 15 in ed71398