Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features to "API Based Weather Report" - #744 #763

Merged
merged 11 commits into from
Jun 8, 2024

Conversation

yanliutafewa
Copy link
Contributor

Type of change

  • Added new project
  • Bug fix
  • [ Y ] New features
  • Enhanced documentation

Changes proposed in this pull request

  • Project name :

API Based Weather Report

  • Short description :

Issue - #744

I improved the functionalities of "API Based Weather Report" by adding features:

Get and present “sunrise time” and “sunset time” for the city. It contains a function to convert the unix timestamp to local time.
Get and present “wind direction”. It contains a function to convert a degree to a direction.
Let user determine whether they want the temperature to be presented in Celsius or Fahrenheit.
Add ‘Country’ to outputs, since some cities have the same name but in different country.
Add output message when the API key is invalid.
Add output message when the city is not found.
To improve the maintainability for the program, I am also added docstrings and unit test class.

Checklist

  • [ Y ] The code is Python 3 compatible
  • [ Y ] I have added relevant comments in my file to make code understandable
  • [ Y ] I have added my project in a folder which includes all the necessary files

Copy link
Contributor

github-actions bot commented Jun 8, 2024

Greetings! This is an automated message from GitHub Actions. 🤖
Your pull request has been received and is awaiting for a review by the repository owner or a maintainer. This may take some time, so please be patient.
While you wait, you can continue to work on other issues or pull requests, or explore the project further. Or you can simply relax and enjoy your day.
Thank you for your contribution to this project! You are awesome! ⭐

@Mrinank-Bhowmick
Copy link
Owner

Thanks for the updates @yanliutafewa

@Mrinank-Bhowmick Mrinank-Bhowmick merged commit 231caa9 into Mrinank-Bhowmick:main Jun 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants