-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code improvements & fix response packet size #22
base: develop
Are you sure you want to change the base?
Conversation
- Get rid of dependencies, cherry-picking modifications from mknjc/minecraft-rcon - Updating to Java 20 - Update dependencies - Some code improvements - Fix incorrect RconResponse response packet size - Move the example and add one - Update README and fix typo
Also print command on error message.
Hi @WarningImHack3r, thank you for the contribution. This is an old project and there are heaps of improvements I would like to make if time permitted 😁 I'm wondering, however, why you suggest to de-Lombok the project, instead of improving the usage of Lombok (there are many opportunities to do this)? |
Hi @MrGraversen! I'm not really the author of that change, it originally comes from https://github.com/mknjc/minecraft-rcon, which I found to be the only fork with (interesting) changes.
|
@MrGraversen I'm currently adding all missing commands, if you want to review the PR with my branch's current state you can do it now, because else everything will be included in the same PR. I plan to push the commit by today or tomorrow. If you don't mind then it's okay. Side notes
|
RconResponse
response packet size