Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libfuzzer] Ignore timeout exit code 124 #465

Merged
merged 2 commits into from
Jul 3, 2024
Merged

[libfuzzer] Ignore timeout exit code 124 #465

merged 2 commits into from
Jul 3, 2024

Conversation

pyoor
Copy link
Contributor

@pyoor pyoor commented Jul 2, 2024

No description provided.

@pyoor pyoor requested a review from a team as a code owner July 2, 2024 15:31
jschwartzentruber
jschwartzentruber approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@jschwartzentruber jschwartzentruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ creates a subshell, [[ is evaluated by bash directly.

services/libfuzzer/launch.sh Outdated Show resolved Hide resolved
@pyoor @jschwartzentruber
Don't use subshell in comparison
7f44668 
Co-authored-by: Jesse Schwartzentruber <truber@mozilla.com>
@jschwartzentruber jschwartzentruber merged commit ccac8cc into master Jul 3, 2024
4 checks passed
@jschwartzentruber jschwartzentruber deleted the libfuzzer-timeout branch July 3, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschwartzentruber jschwartzentruber jschwartzentruber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyoor @jschwartzentruber