Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7918 - Add youtube regrets page extension to parent #7927

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

fessehaye
Copy link
Contributor

@fessehaye fessehaye commented Nov 24, 2021

Add youtube-regrets-extension page type to campaigns

For testing copying the staging db would help!

  1. find youtube regrets banner page on the CMS
  2. Click Add child page
  3. Should be able to add extension page

@mofodevops mofodevops temporarily deployed to foundation-s-7918-pages-fg51qe November 24, 2021 00:15 Inactive
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Simon, this looks good to me! We can then add a YouTube extension page under /YouTube, and thanks to the Max limit we don't have to worry about users creating a duplicate.

If we did want to make sure to avoid confusion, we can also remove it from this list once we create the page in the DB!

@fessehaye fessehaye merged commit 4f30cb0 into main Nov 24, 2021
@fessehaye fessehaye deleted the 7918-pages branch November 24, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants