added UL to tips to protect self #7706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR introduces visual differences. Click here to inspect the diffs. |
|
Hi @Pomax, tagged you in this ticket as I wanted to double check I was working in the correct branches regarding a change to the already-live CMS, and the seperate branch front end product page. Thanks! |
danielfmiranda
temporarily deployed
to
foundation-s-7700-updat-yy2imi
|
This PR introduces visual differences. Click here to inspect the diffs. |
kristinashu
approved these changes
Oct 27, 2021
Pomax
approved these changes
Oct 27, 2021
|
superceded by #7707 |
|
This PR introduces visual differences. Click here to inspect the diffs. |
Pomax
approved these changes
Oct 27, 2021
|
This PR introduces visual differences. Click here to inspect the diffs. |
1 similar comment
|
This PR introduces visual differences. Click here to inspect the diffs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7700
Related PRs/issues #7707
This PR was made to allow the users to add a UL in the "tips to protect yourself" field in the CMS. That way they can just create a bullet point for every "tip" and it will render correctly as a UL on the front end with the changes made in #7707.
Link to sample test page: https://foundation-s-7700-updat-yy2imi.herokuapp.com/cms/pages/23/edit/
Steps to test:
Note: Please note however that since the front end changes have not been merged into master yet, the changes will not appear on the front end.