Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show locally installed games in drop-down when offline #699

Merged
merged 6 commits into from
Jun 30, 2023

Conversation

skaldarnar
Copy link
Member

@skaldarnar skaldarnar commented Jun 30, 2023

Contains

Problem: The launcher knows about locally installed games and could work without internet connection, but the dropdown boxes for games to start uses releases as backing information.

Solution: Take the locally installed games into account when assembling the list of releases shown in the dropdown box.

Closes #198, #199.

How to test

  1. Start the launcher while being connected to the internet, and download a game.
  2. Stop the launcher.
  3. Disconnect from the internet.
  4. Start the launcher.
  5. Ensure that any locally installed games can be selected in the drop-down and started.

There might be a bunch of other things that might be affected by this change:

  • what happens if there is no game installed at all (a) when offline, (b) when online
  • what happens if the installed games change (e.g., by downloading or deleting an game)

Outstanding before merging

  • 463bbd1 There are currently duplicate entries for the same release for installed games, as the the GameRelease fetched from online sources and the dummy GameRelease for locally installed games are not merged.
  • 8cc09c9 When offline, the drop-down is initially empty, even if there are locally installed games.

@skaldarnar skaldarnar added this to the v4.8.0 milestone Jun 30, 2023
@skaldarnar skaldarnar added the Status: WIP Work in Progress (not ready for review) label Jun 30, 2023
@skaldarnar skaldarnar added Type: Bug Bug reports for launcher releases (reproducible from master) Type: Enhancement New features or noticable improvements. labels Jun 30, 2023
Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests out fine. On current master, the drop-down stays empty, on this branch, it's filled with the version(s) I have installed. If I delete my locally installed versions it's empty again.

@skaldarnar skaldarnar merged commit 053f679 into master Jun 30, 2023
3 checks passed
@skaldarnar skaldarnar deleted the fix/show-installed-games-when-offline branch June 30, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: WIP Work in Progress (not ready for review) Type: Bug Bug reports for launcher releases (reproducible from master) Type: Enhancement New features or noticable improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new property "offline mode"
2 participants