build: runtime upgrade to Java 11.0.16.1 (from 11.0.7) #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
reviewed
Aug 21, 2022
skaldarnar
changed the title
skaldarnar
previously approved these changes
Aug 21, 2022
Huh, that is unexpected... maybe something of all these updates messes up our non-modularized launcher? 🤔 |
Also, this version no longer needs the `samedir` property.
skaldarnar
approved these changes
Aug 22, 2022
skaldarnar
added
Type: Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor upgrades to the bundled Java as well as Launcher's library dependencies.
How to test
Seems mostly okay here, but there are some faults in the rendering of the Changelog and documents in the About section. Should check if those are regressions or existing behavior.