fix: append build number to version in JenkinsRepositoryAdapter #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All preview builds of the Omega bundle triggered from engine's `develop` branch have the same display version string (currently "alpha-18"). As this version string is not unique, the launcher treats all those releases as the same (at least in the UI). This PR appends the build number to the version string in the GameIdentifier to be able to distinguish the builds. It's only a quick fix as the launcher should not mangle with version IDs on its own, but just consume them from whatever repository source it connects to... Quick fix for #630
skaldarnar
added
the
Type: Bug
jdrueckert
approved these changes
Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All preview builds of the Omega bundle triggered from engine's
developbranch have the same display version string (currently "alpha-18"). As
this version string is not unique, the launcher treats all those
releases as the same (at least in the UI).
This PR appends the build number to the version string in the
GameIdentifier to be able to distinguish the builds. It's only a quick
fix as the launcher should not mangle with version IDs on its own, but
just consume them from whatever repository source it connects to...
Quick fix for #630