Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher marks releses as installed which are actually not installed #630

Closed
skaldarnar opened this issue Feb 20, 2021 · 1 comment
Closed
Labels
Type: Bug Bug reports for launcher releases (reproducible from master)

Comments

@skaldarnar
Copy link
Member

I assume this is related to the way we compare versions based on the GameIdentifier, and all the preview releases from the "new" Jenkins end up with the same identifier taken from the display version =/ Guess we'll need to do some custom mangling with version ids again...

image

Related:

@skaldarnar skaldarnar added the Type: Bug Bug reports for launcher releases (reproducible from master) label Feb 20, 2021
skaldarnar added a commit that referenced this issue Feb 20, 2021
All preview builds of the Omega bundle triggered from engine's `develop`
branch have the same display version string (currently "alpha-18"). As
this version string is not unique, the launcher treats all those
releases as the same (at least in the UI).

This PR appends the build number to the version string in the
GameIdentifier to be able to distinguish the builds. It's only a quick
fix as the launcher should not mangle with version IDs on its own, but
just consume them from whatever repository source it connects to...

Quick fix for #630
@skaldarnar
Copy link
Member Author

Fixed by #631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports for launcher releases (reproducible from master)
Projects
None yet
Development

No branches or pull requests

1 participant