feat: add Github repository adapter to fetch releases from Github #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will currently run into rate limit problems as we need to do a new request for each release to get the artifacts. I've proposed a PR to hub4j/github-api to fix that. Another option would be to lazily fetch the assets/download URL, but that we way cannot guarantee that the desired asset is present in the release.
|
hub4j/github-api#977 got merged so the technical blockers for this should be gone with the next release of the library 🤓 |
feat: use flexmark in ChangelogViewController feat: only use semver-compliant version from github
skaldarnar
requested review from
jdrueckert and
keturn
and removed request for
jdrueckert
jdrueckert
reviewed
Jun 20, 2021
| @@ -22,7 +21,7 @@ | |||
| import java.util.stream.Collectors; | |||
|
|
|||
| /** | |||
| * Repository adapter for http://jenkins.terasology.io, replacing the {@link LegacyJenkinsRepositoryAdapter}. | |||
| * Repository adapter for http://jenkins.terasology.io. | |||
There was a problem hiding this comment.
Suggested change
| * Repository adapter for http://jenkins.terasology.io. | |
| * Repository adapter for https://jenkins.terasology.io. |
There was a problem hiding this comment.
Technically this adapter still connects to HTTP (I did not change this here, because it does not solve the problem). Should probably do that in another PR
jdrueckert
reviewed
Jun 20, 2021
jdrueckert
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a repository adapter to fetch releases from Github. It will only consider releases tagged with a semver, and skip other releases. It derives whether the build is LWJGLv3 or not by comparing semvers (against v4.1.0-rc.1).
I've tested this with the latest two (preview) releases under Linux Mint.
Old PR description below. This is no longer required to test this PR.
In order to test the Github integration for fetching releases you'll need to build and publish hub4j/github-api#977 locally. To do that, run
mvn clean installand the JAR should be published to the local maven cache where Gradle can grab it from.Use
mavenLocal()as additional repository inbuild.gradleand bump the version fororg.kohsuke:github-apito1.117-SNAPSHOT.Without this patched library, fetching release assets requires a request for each release. As we have 52 of them right now and we're doing some more requests (e.g., to check whether there is a launcher update) this will eat up the free 60 requests per hour with the first start of the launcher...
Another option would be to lazily fetch the assets/download URL, but that we way cannot guarantee that the desired asset is present in the release... 🤔