Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove year from idea copyright template #5221

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented Mar 10, 2024

Based on our discussion on Discord and the resulting decision to remove the year from our in-file copyright notices (see link).

Summary:

There's unclarity on whether the copyright year refers to the date of file creation, last change, or the current year.
Date of creation is hard to track and loses meaning in the light of code changes, moves, or copies.
Current year introduces maintenance overhead, especially for small maintainer groups such as ours.
Many organizations started removing the year from the in-file copyright notices.

Apache License requires us to include a LICENSE and a NOTICE file and to maintain file-level copyright notices.
It doesn't object to changing file-level copyright notices, for instance, removing the year.

@jdrueckert jdrueckert added Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes labels Mar 10, 2024
@jdrueckert jdrueckert added this to the 2023 Revive - Milestone 3 milestone Mar 10, 2024
@jdrueckert jdrueckert self-assigned this Mar 10, 2024
Copy link
Contributor

@BenjaminAmos BenjaminAmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The licence does not appear to mandate a precise form of copyright notice, so this should be acceptable.

@jdrueckert
Copy link
Member Author

The failing integration test is a known sporadic that is unrelated to the changes in this PR.
Merging despite failing checks.

@jdrueckert jdrueckert merged commit b3edb2c into develop Mar 10, 2024
26 of 30 checks passed
@jdrueckert jdrueckert deleted the chore/copyright-remove-year branch March 10, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Chore Request for or implementation of maintenance changes
Projects
Status: No status
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants