Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: consume gestalt v7.2.0 #5210

Merged
merged 2 commits into from
Feb 4, 2024
Merged

chore: consume gestalt v7.2.0 #5210

merged 2 commits into from
Feb 4, 2024

Conversation

jdrueckert
Copy link
Member

How to test

  1. Checkout Terasology into a new workspace (git clone git@github.com:MovingBlocks/Terasology.git myNewTSWorkspace)
  2. Init iota module line-up (./groovyw module init iota)
  3. Try building the game (./gradlew jar) and notice the build failure due to 
     What went wrong:
'int com.github.zafarkhaja.semver.Version.getMajorVersion()'
  4. Checkout this branch (git checkout chore/consume-gestalt-7.2.0)
  5. Try building the game again and notice it succeed

@jdrueckert jdrueckert added Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes labels Feb 4, 2024
@jdrueckert jdrueckert added this to the 2023 Revive - Milestone 3 milestone Feb 4, 2024
@jdrueckert jdrueckert self-assigned this Feb 4, 2024
BenjaminAmos
BenjaminAmos previously approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@BenjaminAmos BenjaminAmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but you might want to update

Terasology/engine/build.gradle

Lines 136 to 139 in 285ba2f

api("org.terasology.gestalt:gestalt-asset-core:7.2.0-SNAPSHOT")
api("org.terasology.gestalt:gestalt-module:7.2.0-SNAPSHOT")
api("org.terasology.gestalt:gestalt-entity-system:7.2.0-SNAPSHOT")
api("org.terasology.gestalt:gestalt-util:7.2.0-SNAPSHOT")
too.

@jdrueckert
Copy link
Member Author

This works but you might want to update

Terasology/engine/build.gradle

Lines 136 to 139 in 285ba2f

api("org.terasology.gestalt:gestalt-asset-core:7.2.0-SNAPSHOT")
api("org.terasology.gestalt:gestalt-module:7.2.0-SNAPSHOT")
api("org.terasology.gestalt:gestalt-entity-system:7.2.0-SNAPSHOT")
api("org.terasology.gestalt:gestalt-util:7.2.0-SNAPSHOT")

too.

Oh right, not sure why I overlooked those ö.Ö
I also used the opportunity to remove the direct semver reference

@BenjaminAmos BenjaminAmos merged commit 397652e into develop Feb 4, 2024
9 checks passed
@BenjaminAmos BenjaminAmos deleted the chore/consume-gestalt-7.2.0 branch February 4, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminAmos BenjaminAmos BenjaminAmos approved these changes

Assignees

@jdrueckert jdrueckert

Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Milestone
2023 Revive - Milestone 3
Development

Successfully merging this pull request may close these issues.
2 participants
@jdrueckert @BenjaminAmos