gradle 8.3, supporting java-21 via its kotlin dependency #5138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soloturn
force-pushed
the
gradle-8.3
branch
from
56c8232
to
4e073e9
Compare
soloturn
changed the title
|
tested with java-21, still good. |
|
@BenjaminAmos am i allowed to ping you here as well? |
BenjaminAmos
requested changes
Sep 24, 2023
| @@ -1,6 +1,6 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-all.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-bin.zip | |||
There was a problem hiding this comment.
Although it is larger, we tend to use the -all gradle distribution because it makes the IDE tooling more useful.
There was a problem hiding this comment.
Suggested change
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-bin.zip | |
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-all.zip |
soloturn
force-pushed
the
gradle-8.3
branch
from
4e073e9
to
c7d9a37
Compare
soloturn
changed the title
BenjaminAmos
approved these changes
Oct 1, 2023
|
To clarify the title here, this will probably only support Java 20. Running on Java 21 will likely need Gradle 8.4 (which is not yet released). It's still an improvement. |
|
should we adjust the title in that case @BenjaminAmos ? |
BenjaminAmos
changed the title
soloturn
changed the title
|
am running java-21. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
permits to remove hardcoded kotlin version again, like mentioned in #5130.